From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755537AbcFQLXW (ORCPT ); Fri, 17 Jun 2016 07:23:22 -0400 Received: from smtprelay0110.hostedemail.com ([216.40.44.110]:54477 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751711AbcFQLXU (ORCPT ); Fri, 17 Jun 2016 07:23:20 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::,RULES_HIT:41:152:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3352:3622:3872:3876:4321:5007:10004:10400:10848:11026:11232:11657:11658:11783:11914:12043:12294:12296:12438:12517:12519:12555:12740:13069:13311:13357:13894:14659:14721:21080:30029:30045:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: cover10_56b942cc24145 X-Filterd-Recvd-Size: 2992 Message-ID: <1466162594.19647.107.camel@perches.com> Subject: Re: [PATCH] brcmfmac: use const char * for interface name in brcmf_add_if From: Joe Perches To: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Kalle Valo Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Pieter-Paul Giesberts , "Franky (Zhenhui) Lin" , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , "open list:NETWORKING DRIVERS" , open list Date: Fri, 17 Jun 2016 04:23:14 -0700 In-Reply-To: <1466160530-32626-1-git-send-email-zajec5@gmail.com> References: <1464378815-23282-1-git-send-email-zajec5@gmail.com> <1466160530-32626-1-git-send-email-zajec5@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-06-17 at 12:48 +0200, Rafał Miłecki wrote: > This function can work just fine with const pointer, it only calls > alloc_netdev which take const as well. Moreover it makes this function > more flexible as some cfg80211 callback may provide const char * as > well, e.g. add_virtual_intf. This will be needed for more advanced > interface management. [] > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c [] > @@ -638,7 +638,7 @@ fail: >  } >   >  struct brcmf_if *brcmf_add_if(struct brcmf_pub *drvr, s32 bsscfgidx, s32 ifidx, > -       bool is_p2pdev, char *name, u8 *mac_addr) > +       bool is_p2pdev, const char *name, u8 *mac_addr) Looks like mac_addr should be const too >  { >   struct brcmf_if *ifp; >   struct net_device *ndev; > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.h [] > @@ -215,7 +215,7 @@ char *brcmf_ifname(struct brcmf_if *ifp); >  struct brcmf_if *brcmf_get_ifp(struct brcmf_pub *drvr, int ifidx); >  int brcmf_net_attach(struct brcmf_if *ifp, bool rtnl_locked); >  struct brcmf_if *brcmf_add_if(struct brcmf_pub *drvr, s32 bsscfgidx, s32 ifidx, > -       bool is_p2pdev, char *name, u8 *mac_addr); > +       bool is_p2pdev, const char *name, u8 *mac_addr); >  void brcmf_remove_interface(struct brcmf_if *ifp, bool rtnl_locked); >  void brcmf_txflowblock_if(struct brcmf_if *ifp, >     enum brcmf_netif_stop_reason reason, bool state);