From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751381AbcFRK6X (ORCPT ); Sat, 18 Jun 2016 06:58:23 -0400 Received: from mail.yifangdigital.com ([121.15.200.100]:4967 "EHLO yifangdigital.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751066AbcFRK6W (ORCPT ); Sat, 18 Jun 2016 06:58:22 -0400 X-Greylist: delayed 320 seconds by postgrey-1.27 at vger.kernel.org; Sat, 18 Jun 2016 06:58:21 EDT From: Guohua Zhong To: Jiri Kosina , Benjamin Tissoires , Mika Westerberg , Dmitry Torokhov , Benson Leung , Andrew Duggan Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Guohua Zhong Subject: [PATCH] HID: i2c-hid: set power sleep before shutdown Date: Sat, 18 Jun 2016 18:50:30 +0800 Message-Id: <1466247030-23047-1-git-send-email-ghzhong@yifangdigital.com> X-Mailer: git-send-email 1.9.1 X-Authenticated-Sender: ghzhong@yifangdigital.com X-Spam-Processed: yifangdigital.com, Sat, 18 Jun 2016 18:52:03 +0800 (not processed: message from valid local sender) X-MDRemoteIP: 192.168.0.9 X-Return-Path: ghzhong@yifangdigital.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add i2c_hid_shutdown for i2c-hid driver to send suspend cmd & disable irq before device shutdown. Some HW design is that the power to i2c hid device won't down after device shutdown. Also the i2c-hid driver do not send suspend cmd to the hid i2c device and disable its irq before shutdown.So if We touch the touchscreen or some other i2c hid device ,the power consumtion will be go up even when the device is in shutdown state. Though the root cause maybe a HW issue. But it seems that it is a good pratice to set power sleep for i2c-hid device before shutdown. Signed-off-by: Guohua Zhong --- drivers/hid/i2c-hid/i2c-hid.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c index 2e021ba..d6ea97b 100644 --- a/drivers/hid/i2c-hid/i2c-hid.c +++ b/drivers/hid/i2c-hid/i2c-hid.c @@ -1106,6 +1106,12 @@ static int i2c_hid_remove(struct i2c_client *client) return 0; } +static void i2c_hid_shutdown(struct i2c_client *client) +{ + i2c_hid_set_power(client, I2C_HID_PWR_SLEEP); + disable_irq(client->irq); +} + #ifdef CONFIG_PM_SLEEP static int i2c_hid_suspend(struct device *dev) { @@ -1230,7 +1236,7 @@ static struct i2c_driver i2c_hid_driver = { .probe = i2c_hid_probe, .remove = i2c_hid_remove, - + .shutdown = i2c_hid_shutdown, .id_table = i2c_hid_id_table, }; -- 1.9.1