From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756104AbcFTRJD (ORCPT ); Mon, 20 Jun 2016 13:09:03 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:32996 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753728AbcFTRI5 (ORCPT ); Mon, 20 Jun 2016 13:08:57 -0400 Subject: Re: [PATCH V2 36/63] clocksource/drivers/time-orion: Convert init function to return error From: Sylvain Lemieux To: Daniel Lezcano Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, Joachim Eastwood , Vladimir Zapolskiy , "moderated list:ARM/LPC18XX ARCHI..." In-Reply-To: <1466112442-31105-37-git-send-email-daniel.lezcano@linaro.org> References: <1466112442-31105-1-git-send-email-daniel.lezcano@linaro.org> <1466112442-31105-37-git-send-email-daniel.lezcano@linaro.org> Content-Type: text/plain; charset="UTF-8" Date: Mon, 20 Jun 2016 13:08:54 -0400 Message-ID: <1466442534.1887.7.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-34.el6) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-06-16 at 23:26 +0200, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and > make the system boot up correctly > > or > > - print an error and let the caller unaware if the state of the system > > Change that by converting the init functions to return an error conforming > to the CLOCKSOURCE_OF_RET prototype. > > Proper error handling (rollback, errno value) will be changed later case > by case, thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano > --- > drivers/clocksource/time-lpc32xx.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/clocksource/time-lpc32xx.c b/drivers/clocksource/time-lpc32xx.c > index daae61e..cb5b866 100644 > --- a/drivers/clocksource/time-lpc32xx.c > +++ b/drivers/clocksource/time-lpc32xx.c > @@ -288,16 +288,16 @@ err_clk_enable: [...] Hi Daniel, please update the patch subject (i.e. replace "time-orion" by "time-lpc32xx). You can add my "Acked-by" to the V3 patch: Acked-by: Sylvain Lemieux