From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751757AbcFUJPb (ORCPT ); Tue, 21 Jun 2016 05:15:31 -0400 Received: from smtprelay0134.hostedemail.com ([216.40.44.134]:37754 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751604AbcFUJPC (ORCPT ); Tue, 21 Jun 2016 05:15:02 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:560:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3865:3870:3872:3874:4321:5007:10004:10400:10848:11232:11658:11914:12296:12517:12519:12740:13069:13311:13357:13439:13894:14659:21080:30034:30054:30064:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: fifth24_48ac0d78fbf12 X-Filterd-Recvd-Size: 1397 Message-ID: <1466500498.26558.12.camel@perches.com> Subject: Re: [PATCH v2] scsi: wd7000: print sector number as 64-bit From: Joe Perches To: Arnd Bergmann , "James E.J. Bottomley" , "Martin K. Petersen" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 21 Jun 2016 02:14:58 -0700 In-Reply-To: <20160621090249.774301-1-arnd@arndb.de> References: <20160621090249.774301-1-arnd@arndb.de> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-06-21 at 11:02 +0200, Arnd Bergmann wrote: > Enabling format checking in dprintk() shows that wd7000_biosparam > uses an incorrect format string for sector_t: trivia: > diff --git a/drivers/scsi/wd7000.c b/drivers/scsi/wd7000.c [] > @@ -192,7 +192,7 @@ >  #ifdef WD7000_DEBUG >  #define dprintk printk >  #else > -#define dprintk(format,args...) > +#define dprintk no_printk >  #endif It'd be nicer if both defines were the same form #ifdef WD7000_DEBUG #define dprintk printk #else #define dprintk no_printk #endif