From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: mathieu.poirier@linaro.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Suzuki K Poulose <suzuki.poulose@arm.com>
Subject: [PATCH v3 1/7] coresight: Remove erroneous dma_free_coherent in tmc_probe
Date: Tue, 21 Jun 2016 17:10:48 +0100 [thread overview]
Message-ID: <1466525454-14702-2-git-send-email-suzuki.poulose@arm.com> (raw)
In-Reply-To: <1466525454-14702-1-git-send-email-suzuki.poulose@arm.com>
commit de5461970b3e9e194 ("coresight: tmc: allocating memory when needed")
removed the static allocation of buffer for the trace data in ETR mode in
tmc_probe. However it failed to remove the "devm_free_coherent" in
tmc_probe when the probe fails due to other reasons. This patch gets
rid of the incorrect dma_free_coherent() call.
Fixes: commit de5461970b3e9e194 ("coresight: tmc: allocating memory when needed")
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
---
drivers/hwtracing/coresight/coresight-tmc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-tmc.c b/drivers/hwtracing/coresight/coresight-tmc.c
index 9e02ac9..3978cbb 100644
--- a/drivers/hwtracing/coresight/coresight-tmc.c
+++ b/drivers/hwtracing/coresight/coresight-tmc.c
@@ -388,9 +388,6 @@ static int tmc_probe(struct amba_device *adev, const struct amba_id *id)
err_misc_register:
coresight_unregister(drvdata->csdev);
err_devm_kzalloc:
- if (drvdata->config_type == TMC_CONFIG_TYPE_ETR)
- dma_free_coherent(dev, drvdata->size,
- drvdata->vaddr, drvdata->paddr);
return ret;
}
--
1.9.1
next prev parent reply other threads:[~2016-06-21 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 16:10 [PATCH v3 0/7] coresight: Miscellaneous fixes Suzuki K Poulose
2016-06-21 16:10 ` Suzuki K Poulose [this message]
2016-06-21 16:10 ` [PATCH v3 2/7] coresight: Consolidate error handling path for tmc_probe Suzuki K Poulose
2016-06-21 16:10 ` [PATCH v3 3/7] coresight: Fix csdev connections initialisation Suzuki K Poulose
2016-06-21 16:10 ` [PATCH v3 4/7] coresight: tmc: Limit the trace to available data Suzuki K Poulose
2016-06-21 16:10 ` [PATCH v3 5/7] coresight: etmv4: Fix ETMv4x peripheral ID table Suzuki K Poulose
2016-06-21 16:10 ` [PATCH v3 6/7] coresight: Cleanup TMC status check Suzuki K Poulose
2016-06-21 16:10 ` [PATCH v3 7/7] coresight: Add better messages for coresight_timeout Suzuki K Poulose
2016-06-21 17:38 ` [PATCH v3 0/7] coresight: Miscellaneous fixes Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466525454-14702-2-git-send-email-suzuki.poulose@arm.com \
--to=suzuki.poulose@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).