From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751939AbcFUTe4 (ORCPT ); Tue, 21 Jun 2016 15:34:56 -0400 Received: from 51.18-broadband.acttv.in ([106.51.18.144]:48439 "EHLO arvind-ThinkPad-Edge-E431" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751568AbcFUTex (ORCPT ); Tue, 21 Jun 2016 15:34:53 -0400 X-Greylist: delayed 3360 seconds by postgrey-1.27 at vger.kernel.org; Tue, 21 Jun 2016 15:34:52 EDT From: Arvind Yadav To: bonbons@linux-vserver.org Cc: jikos@kernel.org, benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Arvind Yadav Subject: [PATCH] HID-PICOLCD: Dummy hid-picolcd functions should return error code Date: Wed, 22 Jun 2016 00:08:40 +0530 Message-Id: <1466534320-31256-1-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org - inline picolcd_fb_reset and picolcd_init_framebuffer stub simply allows compilation on systems with CONFIG_HID_PICOLCD_FB disabled. - inline picolcd_init_backlight and picolcd_resume_backlight stub simply allows compilation on systems with CONFIG_HID_PICOLCD_BACKLIGHT disabled. - inline picolcd_init_lcd and picolcd_resume_lcd stub simply allows compilation on systems with CONFIG_HID_PICOLCD_LCD disabled. - inline picolcd_init_leds stub simply allows compilation on systems with CONFIG_HID_PICOLCD_LEDS disabled. - inline picolcd_init_cir stub simply allows compilation on systems with CONFIG_HID_PICOLCD_CIR disabled. Signed-off-by: Arvind Yadav --- drivers/hid/hid-picolcd.h | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/hid/hid-picolcd.h b/drivers/hid/hid-picolcd.h index e56d847..7e6c10a 100644 --- a/drivers/hid/hid-picolcd.h +++ b/drivers/hid/hid-picolcd.h @@ -17,6 +17,8 @@ * along with this software. If not see . * ***************************************************************************/ +#include + #define PICOLCD_NAME "PicoLCD (graphic)" /* Report numbers */ @@ -192,11 +194,11 @@ void picolcd_fb_refresh(struct picolcd_data *data); #else static inline int picolcd_fb_reset(struct picolcd_data *data, int clear) { - return 0; + return -ENODEV; } static inline int picolcd_init_framebuffer(struct picolcd_data *data) { - return 0; + return -ENOMEM; } static inline void picolcd_exit_framebuffer(struct picolcd_data *data) { @@ -221,14 +223,14 @@ void picolcd_suspend_backlight(struct picolcd_data *data); static inline int picolcd_init_backlight(struct picolcd_data *data, struct hid_report *report) { - return 0; + return -ENODEV; } static inline void picolcd_exit_backlight(struct picolcd_data *data) { } static inline int picolcd_resume_backlight(struct picolcd_data *data) { - return 0; + return -ENODEV; } static inline void picolcd_suspend_backlight(struct picolcd_data *data) { @@ -248,14 +250,14 @@ int picolcd_resume_lcd(struct picolcd_data *data); static inline int picolcd_init_lcd(struct picolcd_data *data, struct hid_report *report) { - return 0; + return -ENODEV; } static inline void picolcd_exit_lcd(struct picolcd_data *data) { } static inline int picolcd_resume_lcd(struct picolcd_data *data) { - return 0; + return -ENODEV; } #endif /* CONFIG_HID_PICOLCD_LCD */ @@ -271,7 +273,7 @@ void picolcd_leds_set(struct picolcd_data *data); static inline int picolcd_init_leds(struct picolcd_data *data, struct hid_report *report) { - return 0; + return -ENODEV; } static inline void picolcd_exit_leds(struct picolcd_data *data) { @@ -297,7 +299,7 @@ static inline int picolcd_raw_cir(struct picolcd_data *data, } static inline int picolcd_init_cir(struct picolcd_data *data, struct hid_report *report) { - return 0; + return -ENOMEM; } static inline void picolcd_exit_cir(struct picolcd_data *data) { -- 1.9.1