From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751188AbcFVFLi (ORCPT ); Wed, 22 Jun 2016 01:11:38 -0400 Received: from ozlabs.org ([103.22.144.67]:43308 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750910AbcFVFLh convert rfc822-to-8bit (ORCPT ); Wed, 22 Jun 2016 01:11:37 -0400 Message-ID: <1466572287.8686.1.camel@neuling.org> Subject: Re: [PATCH v6 07/11] powerpc/powernv: set power_save func after the idle states are initialized From: Michael Neuling To: benh@au1.ibm.com, "Shreyas B. Prabhu" , mpe@ellerman.id.au Cc: ego@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, maddy@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org Date: Wed, 22 Jun 2016 15:11:27 +1000 In-Reply-To: <1466560468.4089.7.camel@au1.ibm.com> References: <1465404871-5406-1-git-send-email-shreyas@linux.vnet.ibm.com> <1465404871-5406-8-git-send-email-shreyas@linux.vnet.ibm.com> <1466560468.4089.7.camel@au1.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-06-22 at 11:54 +1000, Benjamin Herrenschmidt wrote: > On Wed, 2016-06-08 at 11:54 -0500, Shreyas B. Prabhu wrote: > > > > pnv_init_idle_states discovers supported idle states from the > > device tree and does the required initialization. Set power_save > > function pointer only after this initialization is done > > > > Reviewed-by: Gautham R. Shenoy > > Signed-off-by: Shreyas B. Prabhu > Acked-by: Benjamin Herrenschmidt > > Please merge that one as-is now, no need to wait for the rest, as > otherwise pwoer9 crashes at boot. It doesn't need to wait for the > rest of the series. Acked-by: Michael Neuling For the same reason. Without this we need powersave=off on the cmdline on POWER9. Mikey > > Cheers, > Ben. > > > > > --- > > - No changes since v1 > > > >  arch/powerpc/platforms/powernv/idle.c  | 3 +++ > >  arch/powerpc/platforms/powernv/setup.c | 2 +- > >  2 files changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/arch/powerpc/platforms/powernv/idle.c > > b/arch/powerpc/platforms/powernv/idle.c > > index fcc8b68..fbb09fb 100644 > > --- a/arch/powerpc/platforms/powernv/idle.c > > +++ b/arch/powerpc/platforms/powernv/idle.c > > @@ -285,6 +285,9 @@ static int __init pnv_init_idle_states(void) > >   } > >   > >   pnv_alloc_idle_core_states(); > > + > > + if (supported_cpuidle_states & OPAL_PM_NAP_ENABLED) > > + ppc_md.power_save = power7_idle; > >  out_free: > >   kfree(flags); > >  out: > > diff --git a/arch/powerpc/platforms/powernv/setup.c > > b/arch/powerpc/platforms/powernv/setup.c > > index ee6430b..8492bbb 100644 > > --- a/arch/powerpc/platforms/powernv/setup.c > > +++ b/arch/powerpc/platforms/powernv/setup.c > > @@ -315,7 +315,7 @@ define_machine(powernv) { > >   .get_proc_freq          = pnv_get_proc_freq, > >   .progress = pnv_progress, > >   .machine_shutdown = pnv_shutdown, > > - .power_save             = power7_idle, > > + .power_save             = NULL, > >   .calibrate_decr = generic_calibrate_decr, > >  #ifdef CONFIG_KEXEC > >   .kexec_cpu_down = pnv_kexec_cpu_down,