From: <>
To: helgaas@kernel.org
Cc: tglx@linutronix.de, rjw@rjwysocki.net, tony.luck@intel.com,
bhelgaas@google.com, linux-acpi@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
rui.y.wang@intel.com
Subject: Re: [PATCH V4 1/3] x86/ioapic: Support hot-removal of IOAPICs present during boot
Date: Thu, 23 Jun 2016 13:11:41 +0800 [thread overview]
Message-ID: <1466658701-23894-1-git-send-email-rui.y.wang@intel.com> (raw)
In-Reply-To: <20160622151455.GB25485@localhost>
From: Rui Wang <rui.y.wang@intel.com>
On Wed, June 22, 2016 11:15 PM Bjorn Helgaas wrote:
> [...]
> > @@ -1779,8 +1780,12 @@ void __init
> > pci_assign_unassigned_resources(void)
> > {
> > struct pci_bus *root_bus;
> >
> > - list_for_each_entry(root_bus, &pci_root_buses, node)
> > + list_for_each_entry(root_bus, &pci_root_buses, node) {
> > pci_assign_unassigned_root_bus_resources(root_bus);
> > +#ifdef CONFIG_X86
> > + acpi_ioapic_add(ACPI_HANDLE(root_bus->bridge));
> > +#endif
>
> Doesn't this do the right thing even if you omit the #ifdefs, since you
> define a stub function below?
>
No. Without the '#ifdef CONFIG_X86' it breaks MIPS arch. The stub function is
within 'ifdef CONFIG_ACPI'. On archs without ACPI it doesn't compile due to
'undefined reference to acpi_ioapic_add'.
Thanks
Rui
next prev parent reply other threads:[~2016-06-23 5:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 6:59 [PATCH V2 0/3] ioapic hot-removal bugs Rui Wang
2016-06-08 6:59 ` [PATCH V2 1/3] x86/ioapic: Support hot-removal of IOAPICs present during boot Rui Wang
2016-06-08 8:05 ` kbuild test robot
2016-06-08 9:32 ` [PATCH V3 " Rui Wang
2016-06-10 12:57 ` Thomas Gleixner
2016-06-10 13:56 ` Rafael J. Wysocki
2016-06-10 16:43 ` Bjorn Helgaas
2016-06-12 6:06 ` Rui Wang
2016-06-16 17:09 ` Bjorn Helgaas
2016-06-22 7:13 ` Rui Wang
2016-06-22 14:53 ` Bjorn Helgaas
2016-06-24 15:18 ` Rui Wang
2016-06-22 7:40 ` [PATCH V4 " Rui Wang
2016-06-22 15:14 ` Bjorn Helgaas
2016-06-23 5:11 ` [this message]
2016-06-23 17:34 ` Bjorn Helgaas
2016-06-24 15:30 ` Rui Wang
2016-06-26 3:44 ` [PATCH V5 " Rui Wang
2016-08-08 20:22 ` Bjorn Helgaas
2016-08-09 3:23 ` Rui Wang
2016-08-09 12:09 ` Rafael J. Wysocki
2016-06-08 6:59 ` [PATCH V2 2/3] x86/ioapic: Fix wrong pointers in ioapic_setup_resources() Rui Wang
2016-06-10 9:45 ` [tip:x86/urgent] " tip-bot for Rui Wang
2016-06-10 12:01 ` [tip:x86/apic] x86/ioapic: Fix incorrect " tip-bot for Rui Wang
2016-06-10 12:48 ` [tip:x86/urgent] " tip-bot for Rui Wang
2016-06-08 6:59 ` [PATCH V2 3/3] x86/ioapic: Simplify ioapic_setup_resources() Rui Wang
2016-06-10 9:48 ` [tip:x86/apic] " tip-bot for Rui Wang
2016-06-10 12:54 ` tip-bot for Rui Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466658701-23894-1-git-send-email-rui.y.wang@intel.com \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.y.wang@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).