linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] platform:x86: Remove Monitor MWAIT feature dependency
@ 2016-06-23  6:59 ong.hock.yu
  2016-06-23  6:59 ` [PATCH] platform:x86 " ong.hock.yu
  0 siblings, 1 reply; 5+ messages in thread
From: ong.hock.yu @ 2016-06-23  6:59 UTC (permalink / raw)
  To: souvik.k.chakravarty, dvhart, platform-driver-x86, linux-kernel,
	ong.hock.yu

From: "Yu, Ong Hock" <ong.hock.yu@intel.com>

This patch is to remove the MWAIT feature dependency from the driver. Telemetry capability does not depend on this feature.
Please include me in the mailing list as I did not subscripe to open list.

Yu, Ong Hock (1):
  platform:x86 Remove Monitor MWAIT feature dependency

 drivers/platform/x86/intel_telemetry_debugfs.c | 2 +-
 drivers/platform/x86/intel_telemetry_pltdrv.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] platform:x86 Remove Monitor MWAIT feature dependency
  2016-06-23  6:59 [PATCH] platform:x86: Remove Monitor MWAIT feature dependency ong.hock.yu
@ 2016-06-23  6:59 ` ong.hock.yu
  2016-06-28 20:23   ` Darren Hart
  2016-06-29  5:23   ` Darren Hart
  0 siblings, 2 replies; 5+ messages in thread
From: ong.hock.yu @ 2016-06-23  6:59 UTC (permalink / raw)
  To: souvik.k.chakravarty, dvhart, platform-driver-x86, linux-kernel,
	ong.hock.yu

From: "Yu, Ong Hock" <ong.hock.yu@intel.com>

Telemetry capability does not depend on Monitor MWAIT feature.

Signed-off-by: Yu, Ong Hock <ong.hock.yu@intel.com>
---
 drivers/platform/x86/intel_telemetry_debugfs.c | 2 +-
 drivers/platform/x86/intel_telemetry_pltdrv.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c b/drivers/platform/x86/intel_telemetry_debugfs.c
index f5134ac..d76ee59 100644
--- a/drivers/platform/x86/intel_telemetry_debugfs.c
+++ b/drivers/platform/x86/intel_telemetry_debugfs.c
@@ -78,7 +78,7 @@
 #define TELEM_EVT_LEN(x) (sizeof(x)/sizeof((x)[0]))
 
 #define TELEM_DEBUGFS_CPU(model, data) \
-	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&data}
+	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data}
 
 #define TELEM_CHECK_AND_PARSE_EVTS(EVTID, EVTNUM, BUF, EVTLOG, EVTDAT, MASK) { \
 	if (evtlog[index].telem_evtid == (EVTID)) { \
diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
index 09c84a2..e62cee9 100644
--- a/drivers/platform/x86/intel_telemetry_pltdrv.c
+++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
@@ -82,7 +82,7 @@
 #define TELEM_SET_VERBOSITY_BITS(x, y)	((x) |= ((y) << 27))
 
 #define TELEM_CPU(model, data) \
-	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&data }
+	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data }
 
 enum telemetry_action {
 	TELEM_UPDATE = 0,
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] platform:x86 Remove Monitor MWAIT feature dependency
  2016-06-23  6:59 ` [PATCH] platform:x86 " ong.hock.yu
@ 2016-06-28 20:23   ` Darren Hart
  2016-06-29  3:03     ` Chakravarty, Souvik K
  2016-06-29  5:23   ` Darren Hart
  1 sibling, 1 reply; 5+ messages in thread
From: Darren Hart @ 2016-06-28 20:23 UTC (permalink / raw)
  To: ong.hock.yu; +Cc: souvik.k.chakravarty, platform-driver-x86, linux-kernel

On Thu, Jun 23, 2016 at 02:59:58PM +0800, ong.hock.yu@intel.com wrote:
> From: "Yu, Ong Hock" <ong.hock.yu@intel.com>
> 
> Telemetry capability does not depend on Monitor MWAIT feature.
> 
> Signed-off-by: Yu, Ong Hock <ong.hock.yu@intel.com>

Souvik, any objection?

> ---
>  drivers/platform/x86/intel_telemetry_debugfs.c | 2 +-
>  drivers/platform/x86/intel_telemetry_pltdrv.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c b/drivers/platform/x86/intel_telemetry_debugfs.c
> index f5134ac..d76ee59 100644
> --- a/drivers/platform/x86/intel_telemetry_debugfs.c
> +++ b/drivers/platform/x86/intel_telemetry_debugfs.c
> @@ -78,7 +78,7 @@
>  #define TELEM_EVT_LEN(x) (sizeof(x)/sizeof((x)[0]))
>  
>  #define TELEM_DEBUGFS_CPU(model, data) \
> -	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&data}
> +	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data}
>  
>  #define TELEM_CHECK_AND_PARSE_EVTS(EVTID, EVTNUM, BUF, EVTLOG, EVTDAT, MASK) { \
>  	if (evtlog[index].telem_evtid == (EVTID)) { \
> diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
> index 09c84a2..e62cee9 100644
> --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> @@ -82,7 +82,7 @@
>  #define TELEM_SET_VERBOSITY_BITS(x, y)	((x) |= ((y) << 27))
>  
>  #define TELEM_CPU(model, data) \
> -	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&data }
> +	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data }
>  
>  enum telemetry_action {
>  	TELEM_UPDATE = 0,
> -- 
> 1.9.1
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] platform:x86 Remove Monitor MWAIT feature dependency
  2016-06-28 20:23   ` Darren Hart
@ 2016-06-29  3:03     ` Chakravarty, Souvik K
  0 siblings, 0 replies; 5+ messages in thread
From: Chakravarty, Souvik K @ 2016-06-29  3:03 UTC (permalink / raw)
  To: Darren Hart, Yu, Ong Hock; +Cc: platform-driver-x86, linux-kernel

> -----Original Message-----
> From: Darren Hart [mailto:dvhart@infradead.org]
> Sent: Wednesday, June 29, 2016 1:54 AM
> To: Yu, Ong Hock <ong.hock.yu@intel.com>
> Cc: Chakravarty, Souvik K <souvik.k.chakravarty@intel.com>; platform-driver-
> x86@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] platform:x86 Remove Monitor MWAIT feature
> dependency
> 
> On Thu, Jun 23, 2016 at 02:59:58PM +0800, ong.hock.yu@intel.com wrote:
> > From: "Yu, Ong Hock" <ong.hock.yu@intel.com>
> >
> > Telemetry capability does not depend on Monitor MWAIT feature.
> >
> > Signed-off-by: Yu, Ong Hock <ong.hock.yu@intel.com>
Acked-by: Souvik Kumar Chakravarty <souvik.k.chakravarty@intel.com>

> 
> Souvik, any objection?
Seems reasonable, since I have not heard anything break from the Chrome guys as well.

> 
> > ---
> >  drivers/platform/x86/intel_telemetry_debugfs.c | 2 +-
> > drivers/platform/x86/intel_telemetry_pltdrv.c  | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] platform:x86 Remove Monitor MWAIT feature dependency
  2016-06-23  6:59 ` [PATCH] platform:x86 " ong.hock.yu
  2016-06-28 20:23   ` Darren Hart
@ 2016-06-29  5:23   ` Darren Hart
  1 sibling, 0 replies; 5+ messages in thread
From: Darren Hart @ 2016-06-29  5:23 UTC (permalink / raw)
  To: ong.hock.yu; +Cc: souvik.k.chakravarty, platform-driver-x86, linux-kernel

On Thu, Jun 23, 2016 at 02:59:58PM +0800, ong.hock.yu@intel.com wrote:
> From: "Yu, Ong Hock" <ong.hock.yu@intel.com>
> 
> Telemetry capability does not depend on Monitor MWAIT feature.

Thank you Ong Hock, queued to testing for 4.8.
> 
> Signed-off-by: Yu, Ong Hock <ong.hock.yu@intel.com>
> ---
>  drivers/platform/x86/intel_telemetry_debugfs.c | 2 +-
>  drivers/platform/x86/intel_telemetry_pltdrv.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c b/drivers/platform/x86/intel_telemetry_debugfs.c
> index f5134ac..d76ee59 100644
> --- a/drivers/platform/x86/intel_telemetry_debugfs.c
> +++ b/drivers/platform/x86/intel_telemetry_debugfs.c
> @@ -78,7 +78,7 @@
>  #define TELEM_EVT_LEN(x) (sizeof(x)/sizeof((x)[0]))
>  
>  #define TELEM_DEBUGFS_CPU(model, data) \
> -	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&data}
> +	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data}
>  
>  #define TELEM_CHECK_AND_PARSE_EVTS(EVTID, EVTNUM, BUF, EVTLOG, EVTDAT, MASK) { \
>  	if (evtlog[index].telem_evtid == (EVTID)) { \
> diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform/x86/intel_telemetry_pltdrv.c
> index 09c84a2..e62cee9 100644
> --- a/drivers/platform/x86/intel_telemetry_pltdrv.c
> +++ b/drivers/platform/x86/intel_telemetry_pltdrv.c
> @@ -82,7 +82,7 @@
>  #define TELEM_SET_VERBOSITY_BITS(x, y)	((x) |= ((y) << 27))
>  
>  #define TELEM_CPU(model, data) \
> -	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_MWAIT, (unsigned long)&data }
> +	{ X86_VENDOR_INTEL, 6, model, X86_FEATURE_ANY, (unsigned long)&data }
>  
>  enum telemetry_action {
>  	TELEM_UPDATE = 0,
> -- 
> 1.9.1
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-06-29  5:23 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-23  6:59 [PATCH] platform:x86: Remove Monitor MWAIT feature dependency ong.hock.yu
2016-06-23  6:59 ` [PATCH] platform:x86 " ong.hock.yu
2016-06-28 20:23   ` Darren Hart
2016-06-29  3:03     ` Chakravarty, Souvik K
2016-06-29  5:23   ` Darren Hart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).