linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tien Hock Loh <thloh@altera.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>,
	<peppe.cavallaro@st.com>, <alexandre.torgue@st.com>,
	<davem@davemloft.net>, <preid@electromag.com.au>,
	<dinguyen@opensource.altera.com>, <netdev@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<thloh85@gmail.com>, <cnphoon@altera.com>
Subject: Re: [PATCH V4 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga
Date: Thu, 23 Jun 2016 00:02:31 -0700	[thread overview]
Message-ID: <1466665351.23554.16.camel@ubuntu> (raw)
In-Reply-To: <3759495.N5GR8CgQvA@wuerfel>

Hi Arnd,

On Tue, 2016-06-21 at 11:34 +0200, Arnd Bergmann wrote:
> On Tuesday, June 21, 2016 1:46:11 AM CEST thloh@altera.com wrote:
> > diff --git a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
> > index 72d82d6..dd10f2f 100644
> > --- a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
> > +++ b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt
> > @@ -17,9 +17,26 @@ Required properties:
> >  Optional properties:
> >  altr,emac-splitter: Should be the phandle to the emac splitter soft IP node if
> >  		DWMAC controller is connected emac splitter.
> > +phy-mode: The phy mode the ethernet operates in
> > +altr,sgmii_to_sgmii_converter: phandle to the TSE SGMII converter
> > +
> 
> Please use '-' instead of '_' in the property names.

Overlooked this when I were fixing v4, I'll get this fixed.

> 
> Can you explain in the patch description why you can't reference
> the converter using the normal "phy-handle" property and implement
> the converter as a phy driver?
> 

The converter isn't a PHY, but an adapter that handles data stream, and
the phandle is only used to reset the adapter in software's context,
thus it doesn't seem to be correct to implement it as a phy driver. 
Does that answer your question?
If so, do you think we need to document this in the patch description in
this case?

> 	Arnd
> 

Thanks
Tien Hock

  reply	other threads:[~2016-06-23  7:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-21  8:46 [PATCH V4 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga thloh
2016-06-21  9:34 ` Arnd Bergmann
2016-06-23  7:02   ` Tien Hock Loh [this message]
2016-06-22  9:00 ` Giuseppe CAVALLARO
2016-06-23  1:38   ` Tien Hock Loh
2016-06-23  7:58     ` Giuseppe CAVALLARO

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466665351.23554.16.camel@ubuntu \
    --to=thloh@altera.com \
    --cc=alexandre.torgue@st.com \
    --cc=arnd@arndb.de \
    --cc=cnphoon@altera.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@opensource.altera.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=preid@electromag.com.au \
    --cc=robh+dt@kernel.org \
    --cc=thloh85@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).