From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751806AbcF0MNQ (ORCPT ); Mon, 27 Jun 2016 08:13:16 -0400 Received: from mga04.intel.com ([192.55.52.120]:55266 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750870AbcF0MNP (ORCPT ); Mon, 27 Jun 2016 08:13:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,536,1459839600"; d="scan'208";a="984032475" Message-ID: <1467029589.30123.288.camel@linux.intel.com> Subject: Re: [PATCH net-next 6/9] net: hns: normalize two different loop From: Andy Shevchenko To: Joe Perches , Yisen Zhuang , davem@davemloft.net, salil.mehta@huawei.com, yankejian@huawei.com Cc: liguozhu@huawei.com, huangdaode@hisilicon.com, arnd@arndb.de, andrew@lunn.ch, geliangtang@163.com, ivecera@redhat.com, fengguang.wu@intel.com, charles.chenxin@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com Date: Mon, 27 Jun 2016 15:13:09 +0300 In-Reply-To: <1467029338.1847.106.camel@perches.com> References: <1467021255-95900-1-git-send-email-Yisen.Zhuang@huawei.com> <1467021255-95900-7-git-send-email-Yisen.Zhuang@huawei.com> <1467028161.1847.101.camel@perches.com> <1467028835.30123.287.camel@linux.intel.com> <1467029338.1847.106.camel@perches.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-06-27 at 05:08 -0700, Joe Perches wrote: > On Mon, 2016-06-27 at 15:00 +0300, Andy Shevchenko wrote: > > On Mon, 2016-06-27 at 04:49 -0700, Joe Perches wrote: > > > > > > On Mon, 2016-06-27 at 17:54 +0800, Yisen Zhuang wrote: > > > > > > > > From: Daode Huang > > > > > > > > There are two approaches to assign data, one does 2 loops, > > > > another > > > > does 1 loop. This patch normalize the different methods to 1 > > > > loop. > > > [] > > > > > > > > diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c > > > > b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c > > > [] > > > > > > > > @@ -2567,15 +2567,15 @@ static char > > > > *hns_dsaf_get_node_stats_strings(char *data, int node, > > > >   buff += ETH_GSTRING_LEN; > > > >   if (node < DSAF_SERVICE_NW_NUM && !is_ver1) { > > > >   for (i = 0; i < DSAF_PRIO_NR; i++) { > > > > - snprintf(buff, ETH_GSTRING_LEN, > > > > -  "inod%d_pfc_prio%d_pkts", > > > > node, > > > > i); > > > > - buff += ETH_GSTRING_LEN; > > > > - } > > > > - for (i = 0; i < DSAF_PRIO_NR; i++) { > > > > - snprintf(buff, ETH_GSTRING_LEN, > > > > -  "onod%d_pfc_prio%d_pkts", > > > > node, > > > > i); > > > > + snprintf(buff + 0 * ETH_GSTRING_LEN * > > > > DSAF_PRIO_NR, > > > > +  ETH_GSTRING_LEN, > > > > "inod%d_pfc_prio%d_pkts", > > > > +  node, i); > > > > + snprintf(buff + 1 * ETH_GSTRING_LEN * > > > > DSAF_PRIO_NR, > > > > +  ETH_GSTRING_LEN, > > > > "onod%d_pfc_prio%d_pkts", > > > > +  node, i); > > > >   buff += ETH_GSTRING_LEN; > > > This looks odd and likely incorrect. > > Why? the idea is to print stats for Rx and Tx at once. > > > > I hope it was tested. > > It changes the order of the strings in buff. I don't see how. > Is a bug fix or a style fix? > > If it's a bug fix, then it should likely be added > to the stable trees. I doubt it's a bug fix. -- Andy Shevchenko Intel Finland Oy