From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752474AbcF1IrM (ORCPT ); Tue, 28 Jun 2016 04:47:12 -0400 Received: from mail-pf0-f170.google.com ([209.85.192.170]:36543 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752112AbcF1IrK convert rfc822-to-8bit (ORCPT ); Tue, 28 Jun 2016 04:47:10 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Roger Quadros , "Chanwoo Choi" From: Stephen Boyd In-Reply-To: <57721AEA.6010509@ti.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20160626055647.18898-1-stephen.boyd@linaro.org> <5770D847.7060901@ti.com> <146705583219.30684.18055040268826215722@sboyd-linaro> <57721AEA.6010509@ti.com> Message-ID: <146710362771.3879.13924434427129313640@sboyd-linaro> User-Agent: alot/0.3.7 Subject: Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware Date: Tue, 28 Jun 2016 01:47:07 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Roger Quadros (2016-06-27 23:36:26) > On 27/06/16 22:30, Stephen Boyd wrote: > > > > The VBUS notification is done through another piece of hardware. In this > > case it's done by the charger module. I've sent a patch for that[1]. > > Isn't it better if ID event is handled as well in that PMIC driver instead of > creating a separate one here? > > Why do you need ID to be handled outside of the PMIC driver? > You mentioned earlier that some Qualcomm PMICs have ID detection. Sorry I must have confused you. There are two modules in the PMIC that are doing detection here. The charger module is detecting the VBUS event and this misc module is detecting the ID pin. I'm not sure why they're two different blocks, but it is what it is in the hardware.