linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Keerthy <j-keerthy@ti.com>
To: <dmitry.torokhov@gmail.com>, <linus.walleij@linaro.org>,
	<gnurou@gmail.com>, <lee.jones@linaro.org>, <broonie@kernel.org>,
	<tony@atomide.com>
Cc: <linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
	<linux-input@vger.kernel.org>, <robh+dt@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <j-keerthy@ti.com>
Subject: [PATCH v6 5/6]  mfd: tps65218: Use mfd_add_devices instead of  of_platform_populate
Date: Tue, 28 Jun 2016 18:00:53 +0530	[thread overview]
Message-ID: <1467117054-12943-6-git-send-email-j-keerthy@ti.com> (raw)
In-Reply-To: <1467117054-12943-1-git-send-email-j-keerthy@ti.com>

mfd_add_devices enables parsing device tree nodes without compatibles
for regulators and gpio modules. Replace of_platform_populate with
mfd_add_devices. mfd_cell currently is populated with regulators,
gpio and powerbutton.

Acked-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Keerthy <j-keerthy@ti.com>
---

Changes in v4:

  * Regrouped the mfd cells better.

 drivers/mfd/tps65218.c | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/tps65218.c b/drivers/mfd/tps65218.c
index 9bca1b1..13834a0 100644
--- a/drivers/mfd/tps65218.c
+++ b/drivers/mfd/tps65218.c
@@ -33,6 +33,18 @@
 
 #define TPS65218_PASSWORD_REGS_UNLOCK   0x7D
 
+static const struct mfd_cell tps65218_cells[] = {
+	{
+		.name = "tps65218-pwrbutton",
+		.of_compatible = "ti,tps65218-pwrbutton",
+	},
+	{
+		.name = "tps65218-gpio",
+		.of_compatible = "ti,tps65218-gpio",
+	},
+	{ .name = "tps65218-regulator", },
+};
+
 /**
  * tps65218_reg_write: Write a single tps65218 register.
  *
@@ -245,8 +257,10 @@ static int tps65218_probe(struct i2c_client *client,
 
 	tps->rev = chipid & TPS65218_CHIPID_REV_MASK;
 
-	ret = of_platform_populate(client->dev.of_node, NULL, NULL,
-				   &client->dev);
+	ret = mfd_add_devices(tps->dev, PLATFORM_DEVID_AUTO, tps65218_cells,
+			      ARRAY_SIZE(tps65218_cells), NULL, 0,
+			      regmap_irq_get_domain(tps->irq_data));
+
 	if (ret < 0)
 		goto err_irq;
 
-- 
1.9.1

  parent reply	other threads:[~2016-06-28 12:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28 12:30 [PATCH v6 0/6] mfd: tps65218: Clean ups Keerthy
2016-06-28 12:30 ` [PATCH v6 1/6] mfd: tps65218: Remove redundant read wrapper Keerthy
2016-06-28 12:30 ` [PATCH v6 2/6] Documentation: regulator: tps65218: Update examples Keerthy
2016-06-28 12:30 ` [PATCH v6 3/6] input: tps65218-pwrbutton: Add platform_device_id table Keerthy
2016-06-28 17:04   ` Dmitry Torokhov
2016-06-28 12:30 ` [PATCH v6 4/6] gpio: tps65218-gpio: " Keerthy
2016-06-29  8:56   ` Linus Walleij
2016-06-29  9:32     ` Keerthy
2016-07-04  9:50   ` Linus Walleij
2016-07-04  9:57     ` Keerthy
2016-06-28 12:30 ` Keerthy [this message]
2016-06-28 12:30 ` [PATCH v6 6/6] regulator: tps65218: Remove all the compatibles Keerthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467117054-12943-6-git-send-email-j-keerthy@ti.com \
    --to=j-keerthy@ti.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gnurou@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).