From: Johannes Berg <johannes@sipsolutions.net>
To: Yaniv Machani <yanivma@ti.com>,
linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: Maital Hahn <maitalm@ti.com>
Subject: Re: [PATCH 1/4] mac80211: mesh: flush stations before beacons are stopped
Date: Wed, 29 Jun 2016 09:14:19 +0200 [thread overview]
Message-ID: <1467184459.2461.1.camel@sipsolutions.net> (raw)
In-Reply-To: <20160628111307.8784-2-yanivma@ti.com> (sfid-20160628_131058_738638_5F9A964D)
On Tue, 2016-06-28 at 14:13 +0300, Yaniv Machani wrote:
> From: Maital Hahn <maitalm@ti.com>
>
> Some drivers (e.g. wl18xx) expect that the last stage in the
> de-initialization process will be stopping the beacons, similar to
> ap. Update ieee80211_stop_mesh() flow accordingly.
>
How well have you tested that with other drivers?
Changing behaviour to something a single driver desires isn't
necessarily the best thing to do, since there always are multiple
drivers.
If you're able to demonstrate that it works with the other drivers I'm
willing to take that - the change makes sense after all, and it seems
drivers must support this ordering since peers are also removed
dynamically... But still. Don't just make a change like that without
even giving any indication why you think it's fine for other drivers!
johannes
next prev parent reply other threads:[~2016-06-29 7:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 11:13 [PATCH 0/4] Mesh mpm fixes and enhancements Yaniv Machani
2016-06-28 11:13 ` [PATCH 1/4] mac80211: mesh: flush stations before beacons are stopped Yaniv Machani
2016-06-28 11:13 ` [PATCH 2/4] mac80211/cfg: mesh: fix healing time when a mesh peer is disconnecting Yaniv Machani
2016-06-28 11:13 ` [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template Yaniv Machani
2016-06-28 11:13 ` [PATCH 4/4] mac80211: sta_info: max_peers reached falsely Yaniv Machani
2016-06-28 12:56 ` Bob Copeland
2016-06-28 13:05 ` Machani, Yaniv
2016-06-28 14:06 ` [PATCH 3/4] mac80211: mesh: fixed HT ies in beacon template Bob Copeland
2016-06-29 7:17 ` Johannes Berg
2016-07-13 11:15 ` Machani, Yaniv
2016-06-28 12:27 ` [PATCH 2/4] mac80211/cfg: mesh: fix healing time when a mesh peer is disconnecting Bob Copeland
2016-06-28 14:43 ` Machani, Yaniv
2016-06-29 7:14 ` Johannes Berg [this message]
2016-07-13 10:11 ` [PATCH 1/4] mac80211: mesh: flush stations before beacons are stopped Machani, Yaniv
2016-07-13 13:33 ` Bob Copeland
2016-07-13 19:54 ` Machani, Yaniv
2016-08-01 9:38 ` Johannes Berg
2016-06-29 4:43 ` [PATCH 0/4] Mesh mpm fixes and enhancements Julian Calaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467184459.2461.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=maitalm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=yanivma@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).