From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932170AbcF3Xvb (ORCPT ); Thu, 30 Jun 2016 19:51:31 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:34941 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932137AbcF3Xv2 (ORCPT ); Thu, 30 Jun 2016 19:51:28 -0400 From: Markus Mayer To: Robert Moore , Lv Zheng , Rafael Wysocki , Len Brown Cc: Markus Mayer , linux-acpi@vger.kernel.org, devel@acpica.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/6] ACPICA: make use of new strtolower() function Date: Thu, 30 Jun 2016 16:50:09 -0700 Message-Id: <1467330612-26242-4-git-send-email-mmayer@broadcom.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1467330612-26242-1-git-send-email-mmayer@broadcom.com> References: <1467330612-26242-1-git-send-email-mmayer@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Call strtolower() rather than walking the string explicitly to convert it to lowercase. Signed-off-by: Markus Mayer --- *** Please note that there don't seem to be any callers of acpi_ut_strlwr(). *** It may be possible to remove the function altogether. drivers/acpi/acpica/utnonansi.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/acpi/acpica/utnonansi.c b/drivers/acpi/acpica/utnonansi.c index 3465fe2..b6e11dc 100644 --- a/drivers/acpi/acpica/utnonansi.c +++ b/drivers/acpi/acpica/utnonansi.c @@ -64,19 +64,8 @@ ACPI_MODULE_NAME("utnonansi") ******************************************************************************/ void acpi_ut_strlwr(char *src_string) { - char *string; - ACPI_FUNCTION_ENTRY(); - - if (!src_string) { - return; - } - - /* Walk entire string, lowercasing the letters */ - - for (string = src_string; *string; string++) { - *string = (char)tolower((int)*string); - } + strtolower(src_string); } /******************************************************************************* -- 2.7.4