From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932213AbcF3Xvg (ORCPT ); Thu, 30 Jun 2016 19:51:36 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:33047 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932152AbcF3Xva (ORCPT ); Thu, 30 Jun 2016 19:51:30 -0400 From: Markus Mayer To: Nicholas Bellinger , Roland Dreier , Varun Prakash Cc: Markus Mayer , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/6] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower() Date: Thu, 30 Jun 2016 16:50:12 -0700 Message-Id: <1467330612-26242-7-git-send-email-mmayer@broadcom.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1467330612-26242-1-git-send-email-mmayer@broadcom.com> References: <1467330612-26242-1-git-send-email-mmayer@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After introducing generic strtolower(), iscsi_initiatorname_tolower() is no longer needed. Signed-off-by: Markus Mayer --- drivers/target/iscsi/iscsi_target_nego.c | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c index 89d34bd..fa20638 100644 --- a/drivers/target/iscsi/iscsi_target_nego.c +++ b/drivers/target/iscsi/iscsi_target_nego.c @@ -987,21 +987,6 @@ static int iscsi_target_do_login(struct iscsi_conn *conn, struct iscsi_login *lo return 0; } -static void iscsi_initiatorname_tolower( - char *param_buf) -{ - char *c; - u32 iqn_size = strlen(param_buf), i; - - for (i = 0; i < iqn_size; i++) { - c = ¶m_buf[i]; - if (!isupper(*c)) - continue; - - *c = tolower(*c); - } -} - /* * Processes the first Login Request.. */ @@ -1075,7 +1060,7 @@ int iscsi_target_locate_portal( * RFC-3720 3.2.6.1. section c) that says that iSCSI IQNs * are NOT case sensitive. */ - iscsi_initiatorname_tolower(i_buf); + strtolower(i_buf); if (!s_buf) { if (!login->leading_connection) -- 2.7.4