linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>, "Franck Bui" <fbui@suse.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Steven Rostedt" <rostedt@goodmis.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: [PATCH -v4 0/2] printk.devkmsg: Ratelimit it by default
Date: Fri,  8 Jul 2016 11:18:48 +0200	[thread overview]
Message-ID: <1467969530-5215-1-git-send-email-bp@alien8.de> (raw)

From: Borislav Petkov <bp@suse.de>

Hi all,

sorry for spamming so quickly again and not waiting for a week before
resubmitting but I believe the stuff is ready for 4.8.

So here's v4 with all the minor review comments addressed.


Changelog:
----------

v3:

here's v3 integrating Ingo's comments. The thing is called
printk.devkmsg= or printk_devkmsg now, depending on cmdline option or
sysctl.


v2:

here's v2 with the requested sysctl option kernel.printk_kmsg and
locking of the setting when printk.kmsg= is supplied on the command
line.

Patch 1 is unchanged.

Patch 2 has grown the sysctl addition.

v1:

Rostedt is busy so I took Linus' old patch and Steven's last v2 and
split and extended them with the comments people had on the last thread:

https://lkml.kernel.org/r/20160425145606.598329f2@gandalf.local.home

I hope, at least.

So it is ratelimiting by default, with "on" and "off" cmdline options. I
called the option somewhat a bit shorter too: "printk.kmsg"

The current use cases of this and of which I'm aware are:

* debug the kernel and thus shut up all interfering input from
userspace, i.e. boot with "printk.kmsg=off"

* debug userspace (and by that I mean systemd) by booting with
"printk.kmsg=on" so that the ratelimiting is disabled and the kernel log
gets all the spew.

Thoughts?

Please queue,
thanks.

Borislav Petkov (2):
  ratelimit: Extend to print suppressed messages on release
  printk: Add kernel parameter to control writes to /dev/kmsg

 Documentation/kernel-parameters.txt |  6 +++
 Documentation/sysctl/kernel.txt     | 14 ++++++
 include/linux/printk.h              |  7 +++
 include/linux/ratelimit.h           | 38 +++++++++++++---
 kernel/printk/printk.c              | 86 +++++++++++++++++++++++++++++++++----
 kernel/sysctl.c                     |  9 ++++
 lib/ratelimit.c                     | 10 +++--
 7 files changed, 153 insertions(+), 17 deletions(-)

-- 
2.7.3

             reply	other threads:[~2016-07-08  9:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08  9:18 Borislav Petkov [this message]
2016-07-08  9:18 ` [PATCH -v4 1/2] ratelimit: Extend to print suppressed messages on release Borislav Petkov
2016-07-14 20:29   ` Andrew Morton
2016-07-15  4:00     ` Borislav Petkov
2016-07-08  9:18 ` [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg Borislav Petkov
2016-07-14 20:23   ` Andrew Morton
2016-07-14 20:39     ` Steven Rostedt
2016-07-15  4:29     ` Borislav Petkov
2016-07-15  6:21   ` Dave Young
2016-07-15 12:45     ` Borislav Petkov
2016-07-16 10:44       ` Dave Young
2016-07-17  5:40         ` Borislav Petkov
2016-07-18  2:18           ` Dave Young
2016-07-18  4:44             ` Borislav Petkov
2016-07-18  5:20               ` Dave Young
2016-07-18  7:21                 ` Borislav Petkov
2016-07-18  7:38                   ` Dave Young
2016-07-18  8:08                     ` Borislav Petkov
2016-07-18  8:17                       ` Dave Young
2016-07-18  9:06                         ` Borislav Petkov
2016-07-19  0:35                           ` Dave Young
2016-07-19  6:49                             ` Borislav Petkov
2016-07-19  7:02                               ` Dave Young
2016-07-25 15:18                         ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467969530-5215-1-git-send-email-bp@alien8.de \
    --to=bp@alien8.de \
    --cc=akpm@linux-foundation.org \
    --cc=fbui@suse.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).