From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932969AbcGIClB (ORCPT <rfc822;w@1wt.eu>);
	Fri, 8 Jul 2016 22:41:01 -0400
Received: from smtprelay0224.hostedemail.com ([216.40.44.224]:58066 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S932844AbcGICk4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 8 Jul 2016 22:40:56 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3167:3352:3622:3865:3867:3868:3870:4321:5007:6737:10004:10400:10848:11026:11658:11914:12048:12296:12517:12519:12740:13069:13095:13311:13357:13439:13894:14659:14721:21080:21433:30054:30070:30091,0,RBL:error,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:error,Custom_rules:0:0:0,LFtime:2000,LUA_SUMMARY:none
X-HE-Tag: ship48_744714043207
X-Filterd-Recvd-Size: 2069
Message-ID: <1468032048.8360.85.camel@perches.com>
Subject: Re: [tip:x86/debug] printk: Make the printk*once() variants return
 a value
From: Joe Perches <joe@perches.com>
To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, mingo@kernel.org,
        luto@kernel.org, hpa@zytor.com, peterz@infradead.org,
        brgerst@gmail.com, torvalds@linux-foundation.org, tglx@linutronix.de,
        luto@amacapital.net, dvlasenk@redhat.com, fweisbec@gmail.com,
        jpoimboe@redhat.com, bp@suse.de, bp@alien8.de,
        linux-tip-commits@vger.kernel.org
Date: Fri, 08 Jul 2016 19:40:48 -0700
In-Reply-To: <tip-069f0cd00df0abfb9252e0dbdc355e40e6ab75fc@git.kernel.org>
References: <1467671487-10344-3-git-send-email-bp@alien8.de>
	 <tip-069f0cd00df0abfb9252e0dbdc355e40e6ab75fc@git.kernel.org>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.2-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2016-07-08 at 05:08 -0700, tip-bot for Borislav Petkov wrote:
> printk: Make the printk*once() variants return a value
[]
> diff --git a/include/linux/printk.h b/include/linux/printk.h
[]
> @@ -108,11 +108,14 @@ struct va_format {
>   * Dummy printk for disabled debugging statements to use whilst maintaining
>   * gcc's format checking.
>   */
> -#define no_printk(fmt, ...)			\
> -do {						\
> -	if (0)					\
> -		printk(fmt, ##__VA_ARGS__);	\
> -} while (0)
> +#define no_printk(fmt, ...)				\
> +({							\
> +	do {						\
> +		if (0)					\
> +			printk(fmt, ##__VA_ARGS__);	\
> +	} while (0);					\
> +	0;						\
> +})

This change isn't described in the commit message and there
doesn't seem to be a need to change this.

And as statement expressions these no longer need
"do { <foo> } while (0)" this could have been be simplified to

#define no_printk(fmt, ...)
({
	if (0)
		printk(fmt, ##__VA_ARGS__);
})