From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756878AbcGIR5E (ORCPT ); Sat, 9 Jul 2016 13:57:04 -0400 Received: from smtprelay0056.hostedemail.com ([216.40.44.56]:36396 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752022AbcGIR5A (ORCPT ); Sat, 9 Jul 2016 13:57:00 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3167:3352:3622:3865:3867:3868:3870:3871:3872:3873:3874:4321:5007:6119:6248:6742:7903:10004:10226:10400:10848:11232:11658:11914:12296:12517:12519:12663:12740:13069:13095:13311:13357:13439:13894:14659:14721:14777:21080:21326:21433:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: seat61_264d7e49505d X-Filterd-Recvd-Size: 2130 Message-ID: <1468087015.8360.103.camel@perches.com> Subject: Re: [tip:x86/debug] printk: Make the printk*once() variants return a value From: Joe Perches To: Borislav Petkov Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, mingo@kernel.org, luto@kernel.org, hpa@zytor.com, peterz@infradead.org, brgerst@gmail.com, torvalds@linux-foundation.org, tglx@linutronix.de, luto@amacapital.net, dvlasenk@redhat.com, fweisbec@gmail.com, jpoimboe@redhat.com, bp@suse.de, linux-tip-commits@vger.kernel.org Date: Sat, 09 Jul 2016 10:56:55 -0700 In-Reply-To: <20160709075003.GA3822@pd.tnic> References: <1467671487-10344-3-git-send-email-bp@alien8.de> <1468032048.8360.85.camel@perches.com> <20160709075003.GA3822@pd.tnic> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2016-07-09 at 09:50 +0200, Borislav Petkov wrote: > On Fri, Jul 08, 2016 at 07:40:48PM -0700, Joe Perches wrote: > > This change isn't described in the commit message and there > > doesn't seem to be a need to change this. > How do *you* know? Did *you* actually sit down and build a kernel with > your proposed change before sending a reply? > I'm pretty sure you didn't. defconfigs both with and without CONFIG_PRINTK build properly with the proposed change to this specific patch. > Well, there is a very good reason why I made that change but I'm not > going to tell you. Borislav, your delightful personality always impresses. Never change. If there is a specific reason you know why this 0; value must be added to a do {} while (0) to statement expression macro conversion, it'd be good to write that in the commit message.  It'd also be good to remove the useless "do {} while (0);" surrounding a single statement.