From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753458AbcGMRdU (ORCPT ); Wed, 13 Jul 2016 13:33:20 -0400 Received: from mail-db5eur01on0060.outbound.protection.outlook.com ([104.47.2.60]:18945 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752904AbcGMRdK (ORCPT ); Wed, 13 Jul 2016 13:33:10 -0400 Authentication-Results: spf=pass (sender IP is 193.47.165.134) smtp.mailfrom=mellanox.com; synopsys.com; dkim=none (message not signed) header.d=none;synopsys.com; dmarc=pass action=none header.from=mellanox.com; From: Elad Kanfi To: CC: , , , , Subject: [PATCH 1/2] net: nps_enet: fix coding style issues Date: Wed, 13 Jul 2016 16:58:06 +0300 Message-ID: <1468418287-26512-2-git-send-email-eladkan@mellanox.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1468418287-26512-1-git-send-email-eladkan@mellanox.com> References: <1468418287-26512-1-git-send-email-eladkan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.000.1202-22448.007 X-TM-AS-Result: No--1.847100-8.000000-31 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:193.47.165.134;IPV:NLI;CTRY:IL;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(189002)(199003)(6806005)(8676002)(11100500001)(49486002)(86362001)(87936001)(2906002)(2950100001)(50466002)(586003)(47776003)(48376002)(33646002)(77096005)(76176999)(50986999)(4326007)(107886002)(92566002)(110136002)(4001430100002)(7846002)(5003940100001)(81156014)(50226002)(305945005)(356003)(8936002)(36756003)(229853001)(2351001)(189998001)(19580395003)(19580405001)(81166006)(106466001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0501MB2130;H:mtlcas13.mtl.com;FPR:;SPF:Pass;PTR:genko134.voltaire.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11FD022;1:49zU5OMFyMmOOWBQ7okbWEhYSTS2JuAVs8rZ4/OCefdZXmNTLq3InWraCLLJpYdBrsnbcSfhYd23YZ+oOMJyah8IcPwRGYkIoiEZYDQGu8KqUdFr6b7eL2C21Wo174rIf/fP26ELrCXC8resxMIGeGE2V/xufay0kD9X/ezYg9Oha4irDTxYkxCXJTIPiVA0Ug4L2+LzECxtrsAsFSIILw8gLhzgVygb6Sv21fQWh0YrDIrIjSITMhoRrJzpQyFF0721dd/wCCukmnWdtASoHq4exf23qsXXM0/JoUPnO4yfo6KrrxQ+cYofPCo15Wk7FAiuk4u30Xjv+TaArWPqwm3tDpcndSEL29H4DTuOTrVFlMkXDdy48Z6WnHoAuBP15Zu/8lwmfG01nG+7sChzDbiw1ja4UB0CZ/jKS1viLGE4aVPxqQM12Pefcg9fcg76Ch3TTes1gpZUQMxwL5x2vShapYdp4tFV7WDz8U/s3MGG64/qAvOGkDSUe/XtPsEy5e9cma7q2UO9xvmWMr7TJa+s9OZbzDfJ1vAyDyT45Rs= X-MS-Office365-Filtering-Correlation-Id: 53caf880-e8cb-414c-dd85-08d3ab25bb50 X-Microsoft-Exchange-Diagnostics: 1;AM5PR0501MB2130;2:9sv86jXC/ZG1mgs0E8ghsJeWsKPeadvkHq8w9Py+VXp/UQP98nT0ClFHGnfDZ+p1P6DVmxXsG1mOGTyyni6+Ju/EKRcmXL2NOc67dl7Bc4kw/hgIi1lE/pfNJuF1NFB0CAItWLeIx1N+sNJIJBelo8qK0HJRFt4y/OgutKGpOMAxqGXTDwHp1MxmYSzU1ucE;3:0a7GVtD3np1XIU3QFkq7fC7rd05KP2b6jkUIqSNbOxD+MQ1e7RuTf6+eSCBMi3uycHUY726jUS20YEs71qPKxs6elWFatQypVoS6ydmRcjkUoPQTMY45+c93NqyMNSw1rnjxYSNMEIXr43/1Ppvc2qUv/4VxYxC2FIpbvss9JC3aKyhc63A6ziWpkuHPjU1DQRxI/zaSxQXC17Cu5omzZSfHA1fE55oceynugCEUHk731OyuxBo1++xm9NF6eggTdpZAeXRgpxnrYsD8127PVQ==;25:eoETHnyAfYTC5+PsCbTg9acpOYBoeOX7tQZ5+NzikAqlzkqjzp3cX4lvdFe8h+YhppdJkrUb3NbRkUWQC5rZFH2qS7Sv13XU2C1JvX/kR3T4KMvM3hdKTl5/WwhDHJicKo03fjp33uNdwfnrxBLclOcXLtWcDopc4nJJOWnm6/0FjC/vWXs/kmcnGAmyf30k8sia67xV+89GiMRllFCwS4E4TPRxH0bodiyz6xg3Mx25i6W7IeqEvnnkSVH1lVMPc5fRYBmy/Wlip5+L9ZJO2XavYzHe7ekt08UdN8LFsR5M2aQ/uqj1d2SUd87oZIjGV5yC7Ii0nClJLyB/81a7JmBu2GgImkSZtIq8BwDk/S+mdo+vYinXTinFDx1IhaigL3VqtepdnvQ+lXHQWu2OV/GpucjwXZhjLogtRZ2Y4nw= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:AM5PR0501MB2130; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0501MB2130;31:D0YtFpDLRK6KrRq1+14+xgBiwcGrenbWg67lwVJUEOTVaEV/UPGAvlOrFahWH2FRLLyXK5MaweLDoNaGBjBeV22tZM9hgmMwE4ljS/4GxGv91iTtclqrHw2niusHRUvS4deP2iZ0ZPbT9HBt9YJbh8hpuQawUlsQQvYqTBhrgFB6YVbYuhmaLe7ids/Vuj0uCiRJjWXMrUVOYfrI1fhDEQ==;20:RfQhxbtscMcAAG5xWITC+tNqX9eX8TVNWlp5jvi1YTZvbwVOyw3wiYFK0T8jNMcLfYZlLB8CgdFNZmgTxmykNtNjTyPt26W0WYfD6pj38EKwds/tIkk3YT2c9zhb9+t4nt2PH/eI4cXYvc743C958LAsCHhOoPy3JjuFReQMYHS+AtM1VwozbLiq7LrwQpiWV6viO8GjeurHTOsomuYrzmTOBO0/pFwQbAqQT4EjoVCGVRlvmgy74EhDaEP94gWm2etUbK4OScIGRc2wY6o5YrWSt2X9RPgZb2IHkJiubuaibnzlF+xMf5wK5G3wORtHuyhE8bTLc9edXj5exHu6JMJs1/Z/8gEO5NgSyITUq09qK+YdWc3H4rTusRDpnMZX++v6HuHSzx6PdlGgxYwDAaPlR6Dp3K6JkJ7DPeaXj/A8Ka5fx98s2ILlmDDUfYg8u3D/K4Nccw9oiDe7q7hmNK/xl4c96vjLQi31jRkrGZLWyTdqOeyudkCdgrKUN1aP X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(13016025)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:AM5PR0501MB2130;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0501MB2130; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0501MB2130;4:olWHrkdBE4nquCI///ot2l+kfE7DAdl3xj/hakWIRxU3x/TYC7fBFY3a3UQsQLBY5VR4WnFfe1mkZ63tKDcw0xeO813bOn/lfF6nWn1MZFzBRTrE5vgvZdLQSgJd+iXiFCRD5kVCWNWdTT+rDEtpK4GGPRK6ClYtYRNFc5TV7Qx9oGWFvPnKd07MZG+eYKTGUzifGz43hpu66oxdLJweUPxzo+OkUVE6+/LXfxw9vxa4uKBqUEA4STcLzTqZLxRhW06S4Z0Y1w/1DR9RlgHsgzTiF0H+2cqXH8GTW4qSd54WN6jgTEEIaeHH0y5Thpv8StKV2tff+gcvdO0QSMmZyqJm+dI8gPrmBW8noSSUDT6wfxI82iFPabqmoXTPttZow5olq9bEpEz2u4ZtNK/+UProKUhQLwOPAhY3vaamiJM= X-Forefront-PRVS: 000227DA0C X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM5PR0501MB2130;23:kwyeUkJO6+tDXxdnO8JqKuGJG+xV7EI2d8YEUQe?= =?us-ascii?Q?UobHO/aoeIzfeMcXyixH8qhrS2RnuwXxZpfoIUA/Qz5SMiabXnqjTEHsD9Me?= =?us-ascii?Q?Rj2JwTk3OWkVfUGMaRZbYHwY9XCT3bFatJf+clAw3p3Bp2ZfFpjxASkINwI3?= =?us-ascii?Q?esgnwRo+nwuHYV8CIYweC5+XI6TtKOI+HroMbbL7DkXYOC94t+xX5jCqUaY5?= =?us-ascii?Q?mpN+XqPylyE+tA+6iPj3IA4rQE9bNqII2Xs8D6d2dwcsa1DmeeQmRxu7lEut?= =?us-ascii?Q?8ao0wmlsgaCc53mToQ1y2Ej8AjoaftxhI0NrtwBEMzY+JTNN5Vrambvdes7z?= =?us-ascii?Q?6PlwNRkwWM809lhZH7k75vE6gTuoMjt8e07Xmfwhk4na0Mw4V3wlh7ZjeJXK?= =?us-ascii?Q?eRpeaNnXA71HhSORZQK2Wry9jOvHGlJCNdhqLY9fmJEuMD+niZVaeHO8GJ7r?= =?us-ascii?Q?hI/9llANQIVI5cNM0lLb5wm+tQHwGn0JwlhPSuN5HUy3bv2GzOzB0urnddzM?= =?us-ascii?Q?am8WLNJqUw8Jvcn1SBeEBJkumQctzKZ/udzKXiQRjv3PAImIbyfJ1Jx9C3kd?= =?us-ascii?Q?yOQxb3D/tPKFvgpgAKzZmLmsHsoLgd5bLHSZfHsarwAIejAsSod4O17EWJFM?= =?us-ascii?Q?3Cvcg4JxojMEQ3oobDecwyOaebit7Jw/uTxyzCLKs1Gv+aI3WXW37DIRZGQO?= =?us-ascii?Q?CpnEjQVyTVylc330GpH1HH4E53J2tEuIkhfrvgWnWsPHGMki7FYaQXAys7Sl?= =?us-ascii?Q?7W/9qmay0vjQTea8Ix+vXJS19q7He3vsqrbuCZQrTKuXDTjHSOdHu0IOPztf?= =?us-ascii?Q?p6RTe3DHFbOnPg7tEegJ6FTYBIW2E44HEWA7ycn9x86Ps0ecDvgxL9mWXmQM?= =?us-ascii?Q?t7KNlkFRExu6XnTMRF1z3Fz7oSzQMeF74H1QrGW2CB/aSYrh7idxGMuQ9pfk?= =?us-ascii?Q?/ICBnuKVWn2hO4BS2R8sz+QOLfs3qP8K2a1Pv2Vn++hVhawESBcbJ0nMBOQl?= =?us-ascii?Q?4yPcxcyUpLR4uHomV1gZH2z6jEU0/Ltf+WrSnykgqM8gZnXi8ZtgEaX4jhb+?= =?us-ascii?Q?Un+WkgXqZC3pAZEyy5vKsiwg8+Crw?= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0501MB2130;6:OORZV3TpOoaoUfq7LKXMdB24/49Hhxyl6Wp7DwQIx3Hub6Eq9iXcHqvVppkFic/3/GqiiHRzJylgFhSOMG3KhVvs8nKZImxgDGMmdkvR4sCal5YNT5oUhXFe2t2DMMhJDNRnbXbsnZJOUMpwFA8YPjF87dcIZur3rL8UYCaa23Is3mGkVWcKbmm75CI+tuzWq+Ksu4xUboQP1z7ciedAgvbfk9jgQo5S5SLv64Uwpx8VoiT88PhRMrvhuzCVZB/2Pb4ZSdquosLox7QJUDHKwPwVqfYGswnuUBExEfdBnFzNnPPmWysfREnwyU2OecwPYFqmKroQYwVX8eIkFEiedA==;5:7MoPxYUU8Chs4cIfMLTj2bMp0T0AJO0p5RfWp2qS1aYGr3o5VHbclKNLKfwlHbdRO87Eyjh6KOSJ5UBl8Edk50NeMrNCDW7DCVac0u0TdwTJkc62BO9WlTvgU20W9PmB6ZMETDFs8Y6nQnxXadPPNw==;24:FqNUPTg5UOaMczOFxSyGopY9PeOR8uyHKozZTeEa4RdpKSV1CbFI8FDBWJDjZpcT5KCd3HBqV+8ghvqXXjnnK/wC5Dn2Np6Iwj+cI7q4FhA=;7:fuwCfn2+RSlEfgDhRszeiV+e08y+isRvZvS6pYNH2gK9jMJiQQSqzabFZQQU474R22XQpsOzQ5Qv6eNHZPSg28tQFSriR5wZ8D0hRqkEIme52dYAHx2fyTv/DHBC5pTf+rubl54GTDvQC4irChddpeOZQCWEjnqrDm3WWZMa6NzW+vIeYs1ImB56H19HA1ME77tPjMVhM3zVeIghV8z4qeh5QrOiCWYQcTzxpW/weg7EH80G0lSH429Yusmeiy06 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2016 13:58:13.2122 (UTC) X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.134];Helo=[mtlcas13.mtl.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2130 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Elad Kanfi Fix following coding style problems : ERROR: else should follow close brace '}' + } + else { /* !dst_is_aligned */ WARNING: Missing a blank line after declarations + u32 buf = nps_enet_reg_get(priv, NPS_ENET_REG_RX_BUF); + put_unaligned_be32(buf, reg); WARNING: Missing a blank line after declarations + u32 buf; + ioread32_rep(priv->regs_base + NPS_ENET_REG_RX_BUF, &buf, 1); CHECK: Blank lines aren't necessary before a close brace '}' + + } total: 1 errors, 2 warnings, 1 checks, 683 lines checked Signed-off-by: Elad Kanfi --- drivers/net/ethernet/ezchip/nps_enet.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet/ezchip/nps_enet.c index 06f0317..b182e2a 100644 --- a/drivers/net/ethernet/ezchip/nps_enet.c +++ b/drivers/net/ethernet/ezchip/nps_enet.c @@ -46,16 +46,17 @@ static void nps_enet_read_rx_fifo(struct net_device *ndev, if (dst_is_aligned) { ioread32_rep(priv->regs_base + NPS_ENET_REG_RX_BUF, reg, len); reg += len; - } - else { /* !dst_is_aligned */ + } else { /* !dst_is_aligned */ for (i = 0; i < len; i++, reg++) { u32 buf = nps_enet_reg_get(priv, NPS_ENET_REG_RX_BUF); + put_unaligned_be32(buf, reg); } } /* copy last bytes (if any) */ if (last) { u32 buf; + ioread32_rep(priv->regs_base + NPS_ENET_REG_RX_BUF, &buf, 1); memcpy((u8 *)reg, &buf, last); } @@ -459,7 +460,6 @@ static void nps_enet_set_rx_mode(struct net_device *ndev) | NPS_ENET_ENABLE << CFG_2_DISK_DA_SHIFT; ge_mac_cfg_2_value = (ge_mac_cfg_2_value & ~CFG_2_DISK_MC_MASK) | NPS_ENET_ENABLE << CFG_2_DISK_MC_SHIFT; - } nps_enet_reg_set(priv, NPS_ENET_REG_GE_MAC_CFG_2, ge_mac_cfg_2_value); -- 1.7.1