From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751680AbcGMV70 (ORCPT ); Wed, 13 Jul 2016 17:59:26 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:35933 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751425AbcGMV7K convert rfc822-to-8bit (ORCPT ); Wed, 13 Jul 2016 17:59:10 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Sylwester Nawrocki , "Stephen Boyd" From: Michael Turquette In-Reply-To: <578618CA.8090808@samsung.com> Cc: "Paul Gortmaker" , linux-kernel@vger.kernel.org, "Tomasz Figa" , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org References: <20160704211220.5685-1-paul.gortmaker@windriver.com> <20160704211220.5685-8-paul.gortmaker@windriver.com> <578618CA.8090808@samsung.com> Message-ID: <146844714723.73491.8115500341908237496@resonance> User-Agent: alot/0.3.7 Subject: Re: [PATCH 07/10] clk: samsung: make clk-s5pv210-audss explicitly non-modular Date: Wed, 13 Jul 2016 14:59:07 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Sylwester Nawrocki (2016-07-13 03:32:42) > On 07/04/2016 11:12 PM, Paul Gortmaker wrote: > > The Kconfig currently controlling compilation of this code is: > > > > arch/arm/mach-s5pv210/Kconfig:config ARCH_S5PV210 > > arch/arm/mach-s5pv210/Kconfig: bool "Samsung S5PV210/S5PC110" if ARCH_MULTI_V7 > > > > ...meaning that it currently is not being built as a module by anyone. > > > > Lets remove the modular code that is essentially orphaned, so that > > when reading the driver there is no doubt it is builtin-only. > > > > We explicitly disallow a driver unbind, since that doesn't have a > > sensible use case anyway, and it allows us to drop the ".remove" > > code for non-modular drivers. > > > > Since this code is already not using module_init, case, the init > > ordering remains unchanged with this commit. > > > > We also delete the MODULE_LICENSE tags etc. since all that information > > is already contained at the top of the file in the comments. > > > > Cc: Sylwester Nawrocki > > Cc: Tomasz Figa > > Cc: Michael Turquette > > Cc: Stephen Boyd > > Cc: linux-samsung-soc@vger.kernel.org > > Cc: linux-clk@vger.kernel.org > > Signed-off-by: Paul Gortmaker > > In case this is going to be applied directly to current clk-next: > > Acked-by: Sylwester Nawrocki > Applied to clk-next. I know that we normally take PRs for the samsung clk stuff, but this late in the cycle I'm OK to simply pick individual patches. Thanks, Mike