linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luis de Bethencourt <luisbg@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, rusty@rustcorp.com.au,
	hidehiro.kawai.ez@hitachi.com, bp@suse.de, mina86@mina86.com,
	linux@rasmusvillemoes.dk, joe@perches.com,
	philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
	drbd-dev@lists.linbit.com,
	Luis de Bethencourt <luisbg@osg.samsung.com>
Subject: [PATCH v2 2/2] drbd: include dynamic_debug.h in drb_int.h
Date: Wed, 13 Jul 2016 23:10:28 +0100	[thread overview]
Message-ID: <1468447828-18558-2-git-send-email-luisbg@osg.samsung.com> (raw)
In-Reply-To: <1468447828-18558-1-git-send-email-luisbg@osg.samsung.com>

dynamic_debug.h isn't included via kernel.h anymore. Since drbd_int.h needs
it to access dynamic_dev_dbg for dynamic_drbd_dbg, include the header
directly.
Removing inclusion of dynamic_debug.h from drbd_actlog.c since it is
already included via drbd_int.h.

Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
Hi,

Thanks to kbuild test robot for pointing this out [0]

It only happened if CONFIG_DYNAMIC_DEBUG was not set, which is why I
accidentaly missed in my testing.

Luis


[0] https://lists.01.org/pipermail/kbuild-all/2016-July/021902.html

 drivers/block/drbd/drbd_actlog.c | 1 -
 drivers/block/drbd/drbd_int.h    | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/drbd/drbd_actlog.c b/drivers/block/drbd/drbd_actlog.c
index 0a1aaf8..2d3d50a 100644
--- a/drivers/block/drbd/drbd_actlog.c
+++ b/drivers/block/drbd/drbd_actlog.c
@@ -27,7 +27,6 @@
 #include <linux/crc32c.h>
 #include <linux/drbd.h>
 #include <linux/drbd_limits.h>
-#include <linux/dynamic_debug.h>
 #include "drbd_int.h"
 
 
diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h
index 7b54354..4cb8f21 100644
--- a/drivers/block/drbd/drbd_int.h
+++ b/drivers/block/drbd/drbd_int.h
@@ -41,6 +41,7 @@
 #include <linux/backing-dev.h>
 #include <linux/genhd.h>
 #include <linux/idr.h>
+#include <linux/dynamic_debug.h>
 #include <net/tcp.h>
 #include <linux/lru_cache.h>
 #include <linux/prefetch.h>
-- 
2.5.3

      reply	other threads:[~2016-07-13 22:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13 22:10 [PATCH v2 1/2] dynamic_debug: only add header when used Luis de Bethencourt
2016-07-13 22:10 ` Luis de Bethencourt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468447828-18558-2-git-send-email-luisbg@osg.samsung.com \
    --to=luisbg@osg.samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=bp@suse.de \
    --cc=drbd-dev@lists.linbit.com \
    --cc=hidehiro.kawai.ez@hitachi.com \
    --cc=joe@perches.com \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mina86@mina86.com \
    --cc=philipp.reisner@linbit.com \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).