From: Brian Norris <briannorris@chromium.org>
To: Lee Jones <lee.jones@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Olof Johansson <olof@lixom.net>
Cc: <linux-kernel@vger.kernel.org>,
Doug Anderson <dianders@chromium.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Stephen Barber <smbarber@chromium.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo <enric.balletbo@collabora.co.uk>,
Randall Spangler <rspangler@chromium.org>,
Shawn Nematbakhsh <shawnn@chromium.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Todd Broch <tbroch@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Brian Norris <briannorris@chromium.org>
Subject: [PATCH v4 2/4] mfd: cros_ec: add EC_PWM function definitions
Date: Fri, 15 Jul 2016 16:28:42 -0700 [thread overview]
Message-ID: <1468625324-41229-3-git-send-email-briannorris@chromium.org> (raw)
In-Reply-To: <1468625324-41229-1-git-send-email-briannorris@chromium.org>
The EC_CMD_PWM_{GET,SET}_DUTY commands allow us to control a PWM that is
attached to the EC, rather than the main host SoC. The API provides
functionality-based (e.g., keyboard light, backlight) or index-based
addressing of the PWM(s). Duty cycles are represented by a 16-bit value,
where 0 maps to 0% duty cycle and U16_MAX maps to 100%. The period
cannot be controlled.
This command set is more generic than, e.g.,
EC_CMD_PWM_{GET,SET}_KEYBOARD_BACKLIGHT and could possibly used to
replace it on future products.
Let's update the command header to include the definitions.
Signed-off-by: Brian Norris <briannorris@chromium.org>
Acked-by: Lee Jones <lee.jones@linaro.org>
---
v4:
* no change
v3:
* convert from 65535 to 0xffff
v2:
* no changes
---
include/linux/mfd/cros_ec_commands.h | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h
index 13b630c10d4c..7e7a8d4b4551 100644
--- a/include/linux/mfd/cros_ec_commands.h
+++ b/include/linux/mfd/cros_ec_commands.h
@@ -949,6 +949,37 @@ struct ec_params_pwm_set_fan_duty {
uint32_t percent;
} __packed;
+#define EC_CMD_PWM_SET_DUTY 0x25
+/* 16 bit duty cycle, 0xffff = 100% */
+#define EC_PWM_MAX_DUTY 0xffff
+
+enum ec_pwm_type {
+ /* All types, indexed by board-specific enum pwm_channel */
+ EC_PWM_TYPE_GENERIC = 0,
+ /* Keyboard backlight */
+ EC_PWM_TYPE_KB_LIGHT,
+ /* Display backlight */
+ EC_PWM_TYPE_DISPLAY_LIGHT,
+ EC_PWM_TYPE_COUNT,
+};
+
+struct ec_params_pwm_set_duty {
+ uint16_t duty; /* Duty cycle, EC_PWM_MAX_DUTY = 100% */
+ uint8_t pwm_type; /* ec_pwm_type */
+ uint8_t index; /* Type-specific index, or 0 if unique */
+} __packed;
+
+#define EC_CMD_PWM_GET_DUTY 0x26
+
+struct ec_params_pwm_get_duty {
+ uint8_t pwm_type; /* ec_pwm_type */
+ uint8_t index; /* Type-specific index, or 0 if unique */
+} __packed;
+
+struct ec_response_pwm_get_duty {
+ uint16_t duty; /* Duty cycle, EC_PWM_MAX_DUTY = 100% */
+} __packed;
+
/*****************************************************************************/
/*
* Lightbar commands. This looks worse than it is. Since we only use one HOST
--
2.8.0.rc3.226.g39d4020
next prev parent reply other threads:[~2016-07-15 23:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 23:28 [PATCH v4 0/4] pwm: add support for ChromeOS EC PWM Brian Norris
2016-07-15 23:28 ` [PATCH v4 1/4] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper Brian Norris
2016-07-15 23:28 ` Brian Norris [this message]
2016-07-15 23:28 ` [PATCH v4 3/4] doc: dt: pwm: add binding for ChromeOS EC PWM Brian Norris
2016-07-15 23:28 ` [PATCH v4 4/4] pwm: add ChromeOS EC PWM driver Brian Norris
2016-07-18 8:49 ` [PATCH v4 0/4] pwm: add support for ChromeOS EC PWM Lee Jones
2016-07-18 9:10 ` Thierry Reding
2016-07-18 13:24 ` Lee Jones
2016-07-18 14:04 ` Thierry Reding
2016-07-19 7:37 ` Lee Jones
2016-07-25 14:29 ` Thierry Reding
2016-07-18 18:45 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468625324-41229-3-git-send-email-briannorris@chromium.org \
--to=briannorris@chromium.org \
--cc=bleung@chromium.org \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.co.uk \
--cc=gwendal@chromium.org \
--cc=javier@osg.samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rspangler@chromium.org \
--cc=shawnn@chromium.org \
--cc=smbarber@chromium.org \
--cc=tbroch@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).