From: Mel Gorman <mgorman@techsingularity.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Minchan Kim <minchan@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Mel Gorman <mgorman@techsingularity.net>
Subject: [PATCH 1/3] mm, vmscan: Remove redundant check in shrink_zones()
Date: Mon, 18 Jul 2016 15:50:24 +0100 [thread overview]
Message-ID: <1468853426-12858-2-git-send-email-mgorman@techsingularity.net> (raw)
In-Reply-To: <1468853426-12858-1-git-send-email-mgorman@techsingularity.net>
As pointed out by Minchan Kim, shrink_zones() checks for populated
zones in a zonelist but a zonelist can never contain unpopulated
zones. While it's not related to the node-lru series, it can be
cleaned up now.
Suggested-by: Minchan Kim <minchan@kernel.org>
Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
---
mm/vmscan.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 3f06a7a0d135..45344acf52ba 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2605,9 +2605,6 @@ static void shrink_zones(struct zonelist *zonelist, struct scan_control *sc)
for_each_zone_zonelist_nodemask(zone, z, zonelist,
sc->reclaim_idx, sc->nodemask) {
- if (!populated_zone(zone))
- continue;
-
/*
* Take care memory controller reclaiming has small influence
* to global LRU.
--
2.6.4
next prev parent reply other threads:[~2016-07-18 14:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 14:50 [PATCH 0/3] Follow-up fixes to node-lru series v3 Mel Gorman
2016-07-18 14:50 ` Mel Gorman [this message]
2016-07-18 16:11 ` [PATCH 1/3] mm, vmscan: Remove redundant check in shrink_zones() Johannes Weiner
2016-07-18 23:54 ` Minchan Kim
2016-07-18 14:50 ` [PATCH 2/3] mm, vmscan: Release/reacquire lru_lock on pgdat change Mel Gorman
2016-07-18 16:13 ` Johannes Weiner
2016-07-18 23:58 ` Minchan Kim
2016-07-18 14:50 ` [PATCH 3/3] mm, vmstat: remove zone and node double accounting by approximating retries -fix Mel Gorman
2016-07-18 16:14 ` Johannes Weiner
2016-07-18 23:59 ` Minchan Kim
2016-07-18 20:02 ` [PATCH 0/3] Follow-up fixes to node-lru series v3 Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468853426-12858-2-git-send-email-mgorman@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).