From: Oliver Neukum <oneukum@suse.com>
To: Kristian Evensen <kristian.evensen@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling
Date: Tue, 19 Jul 2016 08:20:09 +0200 [thread overview]
Message-ID: <1468909209.2178.0.camel@suse.com> (raw)
In-Reply-To: <CAKfDRXiK82ULw7RnRGdFwzad8NOfnwZN0vqv=08Tf+cNSdyd2g@mail.gmail.com>
On Mon, 2016-07-18 at 17:04 +0200, Kristian Evensen wrote:
> On Mon, Jul 18, 2016 at 4:14 PM, Oliver Neukum <oneukum@suse.com> wrote:
> >> Ok, sounds good. So far, I have only seen the random MAC issue with
> >> the three previously mentioned devices, but who knows how many else is
> >> out there with the same error ... I don't think it should be in the
> >> core ethernet code, at least not yet, but I agree it would make sense
> >> to move it to for example usbnet_core(). If you agree, I can prepare a
> >> patch for it.
> >
> > I don't see how it would be specific for a subsystem. If the patch
> > is correct, it belongs into the networking core.
>
> I had a look at some other drivers, and I think we need to be very
> careful about making setting a random MAC too generic. For example, we
> might be unlucky and break the possibly_iphdr()-code/assumption in
> qmi_wwan.c. And there is probably more code/assumptions like that in
> the network stack.
In this case please use special cases for usbnet, too.
We need a quirk.
Regards
Oliver
next prev parent reply other threads:[~2016-07-19 6:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-18 12:24 [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling Kristian Evensen
2016-07-18 13:01 ` Oliver Neukum
2016-07-18 13:23 ` Kristian Evensen
2016-07-18 13:50 ` Oliver Neukum
2016-07-18 14:10 ` Kristian Evensen
2016-07-18 14:14 ` Oliver Neukum
2016-07-18 14:27 ` Kristian Evensen
2016-07-18 15:04 ` Kristian Evensen
2016-07-19 6:20 ` Oliver Neukum [this message]
2016-07-19 6:40 ` Kristian Evensen
2016-07-19 7:17 ` Oliver Neukum
2016-07-19 8:30 ` Lars Melin
2016-07-19 11:06 ` Kristian Evensen
2016-08-08 12:44 ` Bjørn Mork
2016-08-08 13:57 ` Oliver Neukum
2016-08-08 18:30 ` Bjørn Mork
2016-08-18 8:03 ` Oliver Neukum
2016-07-19 12:14 Andrey Melnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468909209.2178.0.camel@suse.com \
--to=oneukum@suse.com \
--cc=kristian.evensen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).