From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753416AbcGSRuG (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Jul 2016 13:50:06 -0400
Received: from smtprelay0141.hostedemail.com ([216.40.44.141]:55891 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1752364AbcGSRuE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Jul 2016 13:50:04 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:960:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2198:2199:2393:2525:2553:2560:2563:2682:2685:2828:2859:2895:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3350:3622:3865:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:6119:6742:9025:9707:10004:10400:10848:11232:11658:11914:12043:12517:12519:12740:13069:13095:13255:13311:13357:13439:13848:14181:14659:14721:14764:21080:21433:30054:30064:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none
X-HE-Tag: juice57_572adae6c4c06
X-Filterd-Recvd-Size: 1757
Message-ID: <1468950597.1900.56.camel@perches.com>
Subject: Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic
 Network Adapters (ENA)
From: Joe Perches <joe@perches.com>
To: Leon Romanovsky <leon@kernel.org>,
        Netanel Belgazal <netanel@annapurnalabs.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org,
        zorik@annapurnalabs.com, saeed@annapurnalabs.com,
        alex@annapurnalabs.com, msw@amazon.com, aliguori@amazon.com,
        benjamin.poirier@gmail.com, ben@decadent.org.uk, romieu@fr.zoreil.com,
        rami.rosen@intel.com, antoine.tenart@free-electrons.com
Date: Tue, 19 Jul 2016 10:49:57 -0700
In-Reply-To: <20160719172644.GK20674@leon.nu>
References: <1468478774-19942-1-git-send-email-netanel@annapurnalabs.com>
	 <20160715050005.GD30603@leon.nu> <578E0A65.1020105@annapurnalabs.com>
	 <20160719172644.GK20674@leon.nu>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.2-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2016-07-19 at 20:26 +0300, Leon Romanovsky wrote:
> On Tue, Jul 19, 2016 at 02:09:25PM +0300, Netanel Belgazal wrote:
> > This is the debugging message interface.
> > https://www.kernel.org/doc/Documentation/networking/netif-msg.txt
> This document was updated last time in 2006 and I doubt that it is
> relevant in 2016. You have dynamic debug prints infrastructure for it,
> use it.

I think this is uninformed.

netif_<level> works well, is compatible with dynamic debug,
and is commonly used with new networking drivers.