From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754720AbcGVRtI (ORCPT ); Fri, 22 Jul 2016 13:49:08 -0400 Received: from fieldses.org ([173.255.197.46]:40022 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488AbcGVRtF (ORCPT ); Fri, 22 Jul 2016 13:49:05 -0400 From: "J. Bruce Fields" To: Oleg Drokin Cc: Jeff Layton , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, "J. Bruce Fields" , "J. Bruce Fields" Subject: Re: [PATCH] nfsd: Make creates return EEXIST correctly instead of EPERM Date: Fri, 22 Jul 2016 13:48:49 -0400 Message-Id: <1469209736-6490-1-git-send-email-bfields@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-reply-to: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "J. Bruce Fields" On Fri, Jul 22, 2016 at 11:13:20AM -0400, Oleg Drokin wrote: > Hm, in fact indeed. I was just too worked up about the client side, > but on the server side there was a real lookup already, so it does > look workable. So I end up with the following. This is all (after your patch) pretty trivial cleanup, but I think it's overdue for that code. --b. J. Bruce Fields (6): nfsd: remove redundant zero-length check from create nfsd: remove redundant i_lookup check nfsd: reorganize nfsd_create nfsd: remove unnecessary positive-dentry check nfsd: clean up bad-type check in nfsd_create_locked nfsd: drop unnecessary MAY_EXEC check from create Oleg Drokin (1): nfsd: Make creates return EEXIST instead of EACCES fs/nfsd/nfs4proc.c | 3 +- fs/nfsd/nfsproc.c | 7 +-- fs/nfsd/vfs.c | 131 ++++++++++++++++++++++++----------------------------- fs/nfsd/vfs.h | 3 ++ 4 files changed, 66 insertions(+), 78 deletions(-) -- 2.7.4