From: william.c.roberts@intel.com
To: linux-mm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: linux@arm.linux.org.uk, akpm@linux-foundation.org,
keescook@chromium.org, tytso@mit.edu, arnd@arndb.de,
gregkh@linuxfoundation.org, catalin.marinas@arm.com,
will.deacon@arm.com, ralf@linux-mips.org,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, viro@zeniv.linux.org.uk,
nnk@google.com, jeffv@google.com, salyzyn@android.com,
dcashman@android.com,
William Roberts <william.c.roberts@intel.com>
Subject: [PATCH] randomize_range: use random long instead of int
Date: Mon, 25 Jul 2016 11:25:41 -0700 [thread overview]
Message-ID: <1469471141-25669-1-git-send-email-william.c.roberts@intel.com> (raw)
From: William Roberts <william.c.roberts@intel.com>
Use a long when generating the random range rather than
an int. This will produce better random distributions as
well as matching all the types at hand.
Signed-off-by: William Roberts <william.c.roberts@intel.com>
---
drivers/char/random.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/char/random.c b/drivers/char/random.c
index 0158d3b..bbf11b5 100644
--- a/drivers/char/random.c
+++ b/drivers/char/random.c
@@ -1837,7 +1837,8 @@ randomize_range(unsigned long start, unsigned long end, unsigned long len)
if (end <= start + len)
return 0;
- return PAGE_ALIGN(get_random_int() % range + start);
+
+ return PAGE_ALIGN(get_random_long() % range + start);
}
/* Interface for in-kernel drivers of true hardware RNGs.
--
1.9.1
next reply other threads:[~2016-07-25 18:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 18:25 william.c.roberts [this message]
2016-07-25 18:54 ` [PATCH] randomize_range: use random long instead of int Kees Cook
2016-07-26 2:18 ` Jason Cooper
2016-07-26 3:01 ` [RFC patch 1/6] random: Simplify API for random address requests Jason Cooper
2016-07-26 3:01 ` [RFC patch 2/6] x86: Use simpler " Jason Cooper
2016-07-26 3:01 ` [RFC patch 3/6] ARM: " Jason Cooper
2016-07-26 3:01 ` [RFC patch 4/6] arm64: " Jason Cooper
2016-07-26 3:01 ` [RFC patch 5/6] tile: " Jason Cooper
2016-07-26 3:02 ` [RFC patch 6/6] unicore32: " Jason Cooper
2016-07-26 3:30 ` [RFC patch 1/6] random: Simplify " Jason Cooper
2016-07-26 4:39 ` Kees Cook
2016-07-26 17:00 ` Jason Cooper
2016-07-26 17:07 ` Kees Cook
2016-07-28 19:02 ` Jason Cooper
2016-07-26 17:33 ` Roberts, William C
2016-07-26 4:44 ` Kees Cook
2016-07-26 15:55 ` Jason Cooper
2016-07-26 16:40 ` Kees Cook
2016-07-27 13:51 ` [kernel-hardening] " Yann Droneaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469471141-25669-1-git-send-email-william.c.roberts@intel.com \
--to=william.c.roberts@intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=dcashman@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jeffv@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=nnk@google.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=salyzyn@android.com \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).