From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753790AbcG0ISO (ORCPT ); Wed, 27 Jul 2016 04:18:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:37766 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752104AbcG0ISH (ORCPT ); Wed, 27 Jul 2016 04:18:07 -0400 Message-ID: <1469607216.2408.1.camel@suse.com> Subject: Re: [PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments From: Oliver Neukum To: Mathieu OTHACEHE Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Wed, 27 Jul 2016 10:13:36 +0200 In-Reply-To: <20160726180002.2398-11-m.othacehe@gmail.com> References: <20160726180002.2398-1-m.othacehe@gmail.com> <20160726180002.2398-11-m.othacehe@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-07-26 at 19:59 +0200, Mathieu OTHACEHE wrote: > @@ -1626,7 +1624,7 @@ static int ti_write_byte(struct usb_serial_port > *port, > data->bAddrType = TI_RW_DATA_ADDR_XDATA; > data->bDataType = TI_RW_DATA_BYTE; > data->bDataCounter = 1; > - data->wBaseAddrHi = cpu_to_be16(addr>>16); > + data->wBaseAddrHi = cpu_to_be16(addr >> 16); > data->wBaseAddrLo = cpu_to_be16(addr); > data->bData[0] = mask; > data->bData[1] = byte; > -- Hi, this makes me think something is wrong with the data structure. We should have a be32 there, it seems to me. Regards Oliver