From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758965AbcG1Ewx (ORCPT ); Thu, 28 Jul 2016 00:52:53 -0400 Received: from mail-pf0-f177.google.com ([209.85.192.177]:36623 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903AbcG1Ew3 (ORCPT ); Thu, 28 Jul 2016 00:52:29 -0400 From: Binoy Jayan To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Yang Shi , linaro-kernel@lists.linaro.org, bigeasy@linutronix.de, rostedt@goodmis.org, stable-rt@vger.kernel.org, Thomas Gleixner Subject: [PATCH 2/2] trace: Add missing tracer macros Date: Thu, 28 Jul 2016 10:22:14 +0530 Message-Id: <1469681535-25159-3-git-send-email-binoy.jayan@linaro.org> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1469681535-25159-1-git-send-email-binoy.jayan@linaro.org> References: <1469681535-25159-1-git-send-email-binoy.jayan@linaro.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Shi When building rt kernel with IRQSOFF_TRACER enabled but INTERRUPT_OFF_HIST or PREEMPT_OFF_HIST disabled, the below build failure will be triggered: | kernel/trace/trace_irqsoff.c: In function 'time_hardirqs_on': | kernel/trace/trace_irqsoff.c:453:2: error: implicit declaration of | function 'trace_preemptirqsoff_hist_rcuidle' | [-Werror=implicit-function-declaration] | trace_preemptirqsoff_hist_rcuidle(IRQS_ON, 0); | ^ | cc1: some warnings being treated as errors | scripts/Makefile.build:258: recipe for target | 'kernel/trace/trace_irqsoff.o' failed | make[4]: *** [kernel/trace/trace_irqsoff.o] Error 1 | make[4]: *** Waiting for unfinished jobs.... | scripts/Makefile.build:403: recipe for target 'kernel/trace' failed These macros are only defined when both PREEMPT_OFF_HIST and PREEMPT_OFF_HIST are enabled, otherwise just trace_preemptirqsoff_hist is defined as a preprocessor macro. Signed-off-by: Yang Shi Cc: linaro-kernel@lists.linaro.org Cc: bigeasy@linutronix.de Cc: rostedt@goodmis.org Cc: stable-rt@vger.kernel.org Link: http://lkml.kernel.org/r/1445280008-8456-1-git-send-email-yang.shi@linaro.org Signed-off-by: Thomas Gleixner --- include/trace/events/hist.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/trace/events/hist.h b/include/trace/events/hist.h index 6122e42..37f6eb8 100644 --- a/include/trace/events/hist.h +++ b/include/trace/events/hist.h @@ -9,6 +9,7 @@ #if !defined(CONFIG_PREEMPT_OFF_HIST) && !defined(CONFIG_INTERRUPT_OFF_HIST) #define trace_preemptirqsoff_hist(a, b) +#define trace_preemptirqsoff_hist_rcuidle(a, b) #else TRACE_EVENT(preemptirqsoff_hist, @@ -33,6 +34,7 @@ TRACE_EVENT(preemptirqsoff_hist, #ifndef CONFIG_MISSED_TIMER_OFFSETS_HIST #define trace_hrtimer_interrupt(a, b, c, d) +#define trace_hrtimer_interrupt_rcuidle(a, b, c, d) #else TRACE_EVENT(hrtimer_interrupt, -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project