From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161091AbcG1R1S (ORCPT ); Thu, 28 Jul 2016 13:27:18 -0400 Received: from smtprelay0202.hostedemail.com ([216.40.44.202]:34950 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1161025AbcG1R1R (ORCPT ); Thu, 28 Jul 2016 13:27:17 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,:::,RULES_HIT:41:355:379:541:967:973:988:989:1260:1263:1277:1311:1313:1314:1345:1373:1437:1515:1516:1518:1534:1541:1566:1593:1594:1711:1714:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:2975:3000:3022:3138:3139:3140:3141:3142:3622:3870:3871:3876:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:5007:8828:9025:9388:9405:10004:10400:10848:11026:11256:11257:11658:11783:11889:11914:12043:12296:12517:12519:12682:13069:13071:13161:13229:13311:13357:13439:13894:14089:14090:14106:14180:14181:14659:14721:21080:21433:30012:30054:30090,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: plane30_794b78d3b4356 X-Filterd-Recvd-Size: 1561 Message-ID: <1469726831.3998.44.camel@perches.com> Subject: tile-srom and krealloc with __GFP_ZERO defect From: Joe Perches To: Chris Metcalf Cc: LKML Date: Thu, 28 Jul 2016 10:27:11 -0700 Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Chris, There is a defect in krealloc with __GFP_ZERO so this code in drivers/chat/tile-srom.c may not work properly: drivers/char/tile-srom.c-       for (i = 0; ; i++) { drivers/char/tile-srom.c-               int devhdl; drivers/char/tile-srom.c-               char buf[20]; drivers/char/tile-srom.c-               struct srom_dev *new_srom_devices = drivers/char/tile-srom.c-                       krealloc(srom_devices, (i+1) * sizeof(struct srom_dev), drivers/char/tile-srom.c:                                GFP_KERNEL | __GFP_ZERO); drivers/char/tile-srom.c-               if (!new_srom_devices) { drivers/char/tile-srom.c-                       result = -ENOMEM; drivers/char/tile-srom.c-                       goto fail_mem; drivers/char/tile-srom.c-               } drivers/char/tile-srom.c-               srom_devices = new_srom_devices; http://linux-kernel.vger.kernel.narkive.com/xyiQV3vf/slab-krealloc-with-gfp-zero-defect