From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757055AbcG1S6i (ORCPT ); Thu, 28 Jul 2016 14:58:38 -0400 Received: from smtprelay0055.hostedemail.com ([216.40.44.55]:51510 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756059AbcG1S6e (ORCPT ); Thu, 28 Jul 2016 14:58:34 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3866:3867:3868:3870:4321:5007:7903:10004:10400:10848:11026:11232:11658:11783:11914:12043:12296:12517:12519:12740:13069:13161:13229:13311:13357:13439:13618:13894:14181:14659:14721:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: slip94_2d3c12c9a083b X-Filterd-Recvd-Size: 1803 Message-ID: <1469732309.3998.71.camel@perches.com> Subject: Re: [PATCH] Input - elantech: fix debug dump of the current packet From: Joe Perches To: Dmitry Torokhov Cc: Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 28 Jul 2016 11:58:29 -0700 In-Reply-To: <20160728185409.GG16852@dtor-ws> References: <1469699935-23056-1-git-send-email-benjamin.tissoires@redhat.com> <1469730656.3998.63.camel@perches.com> <20160728184003.GE16852@dtor-ws> <1469731797.3998.69.camel@perches.com> <20160728185409.GG16852@dtor-ws> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-07-28 at 11:54 -0700, Dmitry Torokhov wrote: > On Thu, Jul 28, 2016 at 11:49:57AM -0700, Joe Perches wrote: [] > > So use dev_printk(KERN_DEBUG, etc... > #define psmouse_printk(level, psmouse, format, ...) \ > dev_printk(level, \ >    &(psmouse)->ps2dev.serio->dev, \ >    psmouse_fmt(format), ##__VA_ARGS__) > > I want to see current protocol module in th eoutput and I do not want to > write "&(psmouse)->ps2dev.serio->dev" all the time. There are only 2 uses of the macro. $ git grep psmouse_printk drivers/input/mouse/elantech.c:                 psmouse_printk(KERN_DEBUG, psmouse,             \ drivers/input/mouse/elantech.c: psmouse_printk(KERN_DEBUG, psmouse, "PS/2 packet ["); drivers/input/mouse/psmouse.h:#define psmouse_printk(level, psmouse, format, ...)       \