From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754492AbcG3DDp (ORCPT ); Fri, 29 Jul 2016 23:03:45 -0400 Received: from omzsmtpe03.verizonbusiness.com ([199.249.25.208]:7920 "EHLO omzsmtpe03.verizonbusiness.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754195AbcG3DDP convert rfc822-to-8bit (ORCPT ); Fri, 29 Jul 2016 23:03:15 -0400 X-IronPort-Anti-Spam-Filtered: false From: "Levin, Alexander" Cc: "linux-kernel@vger.kernel.org" , Ben Hutchings , "Levin, Alexander" X-IronPort-AV: E=Sophos;i="5.28,442,1464652800"; d="scan'208";a="1246630867" To: "mingo@redhat.com" , "peterz@infradead.org" Date: Fri, 29 Jul 2016 23:02:14 -0400 Subject: [PATCH 6/8] liblockdep: Fix 'set but not used' warnings Thread-Topic: [PATCH 6/8] liblockdep: Fix 'set but not used' warnings Thread-Index: AdHqDsYcLQ3/oRq6Sk+4djqNbwL61Q== Message-ID: <1469847222-21313-7-git-send-email-alexander.levin@verizon.com> References: <1469847222-21313-1-git-send-email-alexander.levin@verizon.com> In-Reply-To: <1469847222-21313-1-git-send-email-alexander.levin@verizon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ben Hutchings liblockdep defines trivial macros for working with interrupt flags, as interrupts are never disabled in userland. This results in warnings from gcc when -Wunused-but-set-variable is enabled, and it is enabled by -Wall. Fix this by evaluating the flags parameter and casting it to void. Signed-off-by: Ben Hutchings Signed-off-by: Sasha Levin --- tools/lib/lockdep/uinclude/linux/irqflags.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/lib/lockdep/uinclude/linux/irqflags.h b/tools/lib/lockdep/uinclude/linux/irqflags.h index 6cc296f..df77669 100644 --- a/tools/lib/lockdep/uinclude/linux/irqflags.h +++ b/tools/lib/lockdep/uinclude/linux/irqflags.h @@ -17,19 +17,19 @@ #define raw_local_irq_disable() do { } while (0) #define raw_local_irq_enable() do { } while (0) #define raw_local_irq_save(flags) ((flags) = 0) -#define raw_local_irq_restore(flags) do { } while (0) +#define raw_local_irq_restore(flags) ((void)(flags)) #define raw_local_save_flags(flags) ((flags) = 0) -#define raw_irqs_disabled_flags(flags) do { } while (0) +#define raw_irqs_disabled_flags(flags) ((void)(flags)) #define raw_irqs_disabled() 0 #define raw_safe_halt() #define local_irq_enable() do { } while (0) #define local_irq_disable() do { } while (0) #define local_irq_save(flags) ((flags) = 0) -#define local_irq_restore(flags) do { } while (0) +#define local_irq_restore(flags) ((void)(flags)) #define local_save_flags(flags) ((flags) = 0) #define irqs_disabled() (1) -#define irqs_disabled_flags(flags) (0) +#define irqs_disabled_flags(flags) ((void)(flags), 0) #define safe_halt() do { } while (0) #define trace_lock_release(x, y) -- 2.7.4