From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751203AbcG3JyX (ORCPT ); Sat, 30 Jul 2016 05:54:23 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:34928 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbcG3JyQ (ORCPT ); Sat, 30 Jul 2016 05:54:16 -0400 From: Nadim almas To: labbott@redhat.com Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Nadim almas Subject: [PATCH 33/33] Staging: android: ion: ion.c: Compression of lines for Date: Sat, 30 Jul 2016 02:54:06 -0700 Message-Id: <1469872446-7465-1-git-send-email-nadim.902@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch compresses two lines in to a single line in file rtw_android.c if immediate return statement is found. It also removes variable bytes_written as it is no longer needed. It is done using script Coccinelle. And coccinelle uses following semantic patch for this compression function: @@ expression e, ret; @@ -ret = +return e; -return ret; Signed-off-by: Nadim Almas --- drivers/staging/android/ion/ion.c | 8 +++----- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 52345df..271395b 100644 --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -391,9 +391,7 @@ static int ion_handle_put_nolock(struct ion_handle *handle) { - int ret; - ret = kref_put(&handle->ref, ion_handle_destroy); - - return ret; + return kref_put(&handle->ref, ion_handle_destroy); } static int ion_handle_put(struct ion_handle *handle) @@ -597,8 +595,8 @@ int ion_phys(struct ion_client *client, struct ion_handle *handle, return -ENODEV; } mutex_unlock(&client->lock); - ret = buffer->heap->ops->phys(buffer->heap, buffer, addr, len); - return ret; + + return buffer->heap->ops->phys(buffer->heap, buffer, addr, len); } EXPORT_SYMBOL(ion_phys);