From: Dave Hansen <dave.hansen@intel.com>
To: Tian Tao <tiantao6@hisilicon.com>,
corbet@lwn.net, gregkh@linuxfoundation.org,
song.bao.hua@hisilicon.com
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Valentin Schneider <valentin.schneider@arm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>
Subject: Re: [PATCH 1/2] CPU, NUMA topology ABIs: clarify the overflow issue of sysfs pagebuf
Date: Thu, 29 Apr 2021 07:21:13 -0700 [thread overview]
Message-ID: <146e051b-603c-a6d3-43d8-d083cf2c8119@intel.com> (raw)
In-Reply-To: <1619679819-45256-2-git-send-email-tiantao6@hisilicon.com>
On 4/29/21 12:03 AM, Tian Tao wrote:
> diff --git a/Documentation/ABI/stable/sysfs-devices-node b/Documentation/ABI/stable/sysfs-devices-node
> index 484fc04..82dfe64 100644
> --- a/Documentation/ABI/stable/sysfs-devices-node
> +++ b/Documentation/ABI/stable/sysfs-devices-node
> @@ -47,7 +47,10 @@ What: /sys/devices/system/node/nodeX/cpulist
> Date: October 2002
> Contact: Linux Memory Management list <linux-mm@kvack.org>
> Description:
> - The CPUs associated to the node.
> + The CPUs associated to the node. The format is like 0-3,
> + 8-11, 14,17. maximum size is PAGE_SIZE, so the tail
> + of the string will be trimmed while its size is larger
> + than PAGE_SIZE.
I think it's pretty arguable that truncating output on a real system is
an ABI break. Doing this would make the interface rather useless.
Don't we need a real solution rather than throwing up our hands?
Do we think >PAGE_SIZE data out of a sysfs file is a worse ABI break or
something?
next prev parent reply other threads:[~2021-04-29 14:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 7:03 [PATCH 0/2] clarify and cleanup CPU and NUMA topology ABIs Tian Tao
2021-04-29 7:03 ` [PATCH 1/2] CPU, NUMA topology ABIs: clarify the overflow issue of sysfs pagebuf Tian Tao
2021-04-29 14:21 ` Dave Hansen [this message]
2021-04-29 15:46 ` Greg KH
2021-04-29 21:08 ` Song Bao Hua (Barry Song)
2021-04-29 21:38 ` Dave Hansen
2021-04-29 22:32 ` Song Bao Hua (Barry Song)
2021-04-29 22:38 ` Dave Hansen
2021-04-29 22:48 ` Song Bao Hua (Barry Song)
2021-04-30 6:05 ` gregkh
2021-07-23 11:20 ` Song Bao Hua (Barry Song)
2021-07-23 11:28 ` gregkh
2021-07-23 12:48 ` Song Bao Hua (Barry Song)
2021-05-06 23:16 ` kernel test robot
2021-04-29 7:03 ` [PATCH 2/2] Documentation/ABI: Move the topology-related sysfs interface to the right place Tian Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=146e051b-603c-a6d3-43d8-d083cf2c8119@intel.com \
--to=dave.hansen@intel.com \
--cc=bristot@redhat.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=song.bao.hua@hisilicon.com \
--cc=tiantao6@hisilicon.com \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).