From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753379AbcHAL54 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 1 Aug 2016 07:57:56 -0400
Received: from mail-wm0-f43.google.com ([74.125.82.43]:38016 "EHLO
	mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753199AbcHAL5s (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 1 Aug 2016 07:57:48 -0400
Message-ID: <1470052348.5903.6.camel@gmail.com>
Subject: Re: [PATCH 4/4] sched,fair: Fix PELT integrity for new tasks
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Yuyang Du <yuyang.du@intel.com>,
        Ingo Molnar <mingo@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Benjamin Segall <bsegall@google.com>, Paul Turner <pjt@google.com>,
        Morten Rasmussen <morten.rasmussen@arm.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Vincent Guittot <vincent.guittot@linaro.org>
Date: Mon, 01 Aug 2016 13:52:28 +0200
In-Reply-To: <CANRm+CyCPpV2qbydP76fNWyRxUL-eZvr=i=oRUL1pb74ymPB0Q@mail.gmail.com>
References: <20160617120136.064100812@infradead.org>
	 <20160617120454.150630859@infradead.org>
	 <CANRm+Cw3ZcadLrgRh6MKVdFnCc97AQSb2kOra07m_u6EgbzUzg@mail.gmail.com>
	 <1470043872.5903.5.camel@gmail.com>
	 <CANRm+CyCPpV2qbydP76fNWyRxUL-eZvr=i=oRUL1pb74ymPB0Q@mail.gmail.com>
Content-Type: text/plain; charset="us-ascii"
X-Mailer: Evolution 3.16.5 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2016-08-01 at 17:56 +0800, Wanpeng Li wrote:
> 2016-08-01 17:31 GMT+08:00 Mike Galbraith <umgwanakikbuti@gmail.com>:
> > On Mon, 2016-08-01 at 15:30 +0800, Wanpeng Li wrote:
> > 
> > > What's the meaning of "the task is hashed before we call
> > > wake_up_new_task()"?
> > 
> > See fork.c::copy_process()
> > 
> >         /*
> >          * Make it visible to the rest of the system, but dont wake
> > it up yet.
> >          * Need tasklist lock for parent etc handling!
> >          */
> >         write_lock_irq(&tasklist_lock);
> >         ....
> 
> Thanks Mike, so here "is hashed" means that add to list instead of 
> real hashing.

Yeah.

	-Mike