From: Oliver Neukum <oneukum@suse.com>
To: robert.foss@collabora.com
Cc: pprabhu@chromium.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error
Date: Tue, 02 Aug 2016 14:23:15 +0200 [thread overview]
Message-ID: <1470140595.30985.20.camel@suse.com> (raw)
In-Reply-To: <1469729992-6228-1-git-send-email-robert.foss@collabora.com>
On Thu, 2016-07-28 at 14:19 -0400, robert.foss@collabora.com wrote:
> From: Prathmesh Prabhu <pprabhu@chromium.org>
>
> Implemented queued response handling. This queue is processed every
> time the
> WDM_READ flag is cleared.
>
> In case of a read error, userspace may not actually read the data,
> since the
> driver returns an error through wdm_poll. After this, the underlying
> device may
> attempt to send us more data, but the queue is not processed. While
> userspace is
> also blocked, because the read error is never cleared.
Could you explain why user space cannot just read more data?
That will clear the error.
Regards
Oliver
next prev parent reply other threads:[~2016-08-02 14:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 18:19 [PACTH v1] cdc-wdm: Clear read pipeline in case of error robert.foss
2016-08-02 12:23 ` Oliver Neukum [this message]
2016-08-02 13:54 ` Robert Foss
2016-08-02 13:59 ` Oliver Neukum
2016-08-02 14:37 ` Robert Foss
2016-08-03 10:39 ` Oliver Neukum
2016-08-04 17:44 ` Robert Foss
2016-08-07 8:59 ` Oliver Neukum
2016-08-08 14:38 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470140595.30985.20.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pprabhu@chromium.org \
--cc=robert.foss@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).