From: Joe Perches <joe@perches.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Look for symbolic permissions and suggest octal instead
Date: Tue, 02 Aug 2016 17:30:12 -0700 [thread overview]
Message-ID: <1470184212.3998.211.camel@perches.com> (raw)
In-Reply-To: <20160803001520.GE2356@ZenIV.linux.org.uk>
On Wed, 2016-08-03 at 01:15 +0100, Al Viro wrote:
> On Tue, Aug 02, 2016 at 04:39:24PM -0700, Joe Perches wrote:
> >
> > S_ uses should be avoided where octal is more intelligible.
> Oh, for Cthulhu sake! So not only we had been dribbled upon with 1200-odd
> piles of pointless crap, now we'll be getting yet another set of equally
> pointless garbage each time a bored wanker gets to run checkpatch.pl?
>
> Leave that alone. In either direction. Dipshits on quest for commit count
> have enough tools already, no need to add another one...
Well, we disagree.
Use like DEVICE_ATTR are a mix of S_<FOO> vs octal (~3:1)
and a single style can be easier to grep for misuses.
Crud like this doesn't need to be cleaned up all at once and
checkpatch can be useful to encourage whatever preferred
style is desired.
next prev parent reply other threads:[~2016-08-03 0:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 20:58 Please don't replace numeric parameter like 0444 with macro Linus Torvalds
2016-08-02 21:53 ` Rob Landley
2016-08-02 23:39 ` [PATCH] checkpatch: Look for symbolic permissions and suggest octal instead Joe Perches
2016-08-03 0:15 ` Al Viro
2016-08-03 0:30 ` Joe Perches [this message]
2016-08-15 16:38 ` Joe Perches
2016-08-03 0:42 ` Please don't replace numeric parameter like 0444 with macro Al Viro
2016-08-03 8:07 ` Konstantin Khlebnikov
2016-08-03 8:30 ` Richard Weinberger
2016-08-03 8:11 ` [PATCH] Add file permission mode helpers Ingo Molnar
2016-08-03 8:28 ` Greg Kroah-Hartman
2016-08-03 8:39 ` Ingo Molnar
2016-08-03 9:21 ` Willy Tarreau
2016-08-03 9:53 ` Marcel Holtmann
2016-08-03 15:49 ` Joe Perches
2016-08-03 16:38 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470184212.3998.211.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).