From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756849AbcHCAaY (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Aug 2016 20:30:24 -0400
Received: from smtprelay0026.hostedemail.com ([216.40.44.26]:55539 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1753757AbcHCAaQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Aug 2016 20:30:16 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3866:3867:3868:3870:3871:3874:4321:5007:7903:9040:10004:10400:10848:11232:11658:11783:11914:12296:12517:12519:12740:13069:13076:13311:13357:13439:13894:14181:14659:14721:21080:21434:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none
X-HE-Tag: road98_1f1c23e01d950
X-Filterd-Recvd-Size: 1857
Message-ID: <1470184212.3998.211.camel@perches.com>
Subject: Re: [PATCH] checkpatch: Look for symbolic permissions and suggest
 octal instead
From: Joe Perches <joe@perches.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Andy Whitcroft <apw@canonical.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Date: Tue, 02 Aug 2016 17:30:12 -0700
In-Reply-To: <20160803001520.GE2356@ZenIV.linux.org.uk>
References: <CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ@mail.gmail.com>
	 <7232ef011d05a92f4caa86a5e9830d87966a2eaf.1470180926.git.joe@perches.com>
	 <20160803001520.GE2356@ZenIV.linux.org.uk>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.2-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2016-08-03 at 01:15 +0100, Al Viro wrote:
> On Tue, Aug 02, 2016 at 04:39:24PM -0700, Joe Perches wrote:
> > 
> > S_ uses should be avoided where octal is more intelligible.
> Oh, for Cthulhu sake!  So not only we had been dribbled upon with 1200-odd
> piles of pointless crap, now we'll be getting yet another set of equally
> pointless garbage each time a bored wanker gets to run checkpatch.pl?
> 
> Leave that alone.  In either direction.  Dipshits on quest for commit count
> have enough tools already, no need to add another one...

Well, we disagree.

Use like DEVICE_ATTR are a mix of S_<FOO> vs octal (~3:1)
and a single style can be easier to grep for misuses.

Crud like this doesn't need to be cleaned up all at once and
checkpatch can be useful to encourage whatever preferred
style is desired.