From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756542AbcHCPth (ORCPT ); Wed, 3 Aug 2016 11:49:37 -0400 Received: from smtprelay0148.hostedemail.com ([216.40.44.148]:55919 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751535AbcHCPtd (ORCPT ); Wed, 3 Aug 2016 11:49:33 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2692:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6691:7522:10004:10400:10848:11232:11658:11914:12043:12296:12517:12519:12740:13069:13075:13138:13231:13311:13357:13439:13894:14181:14659:14721:21080:21324:21433:30030:30034:30054:30060:30064:30070:30071:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: bells24_3583e20231056 X-Filterd-Recvd-Size: 2507 Message-ID: <1470239366.3998.227.camel@perches.com> Subject: Re: [PATCH] Add file permission mode helpers From: Joe Perches To: Ingo Molnar , Linus Torvalds Cc: Pavel Machek , Greg Kroah-Hartman , Heiko Carstens , Baole Ni , Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List , chuansheng.liu@intel.com Date: Wed, 03 Aug 2016 08:49:26 -0700 In-Reply-To: <20160803081140.GA7833@gmail.com> References: <20160803081140.GA7833@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-08-03 at 10:11 +0200, Ingo Molnar wrote: > * Linus Torvalds wrote: > > [ So I answered similarly to another patch, but I'll just re-iterate > > and change the subject line so that it stands out a bit from the > > millions of actual patches ] > > > > On Tue, Aug 2, 2016 at 1:42 PM, Pavel Machek wrote: > > > Everyone knows what 0644 is, but noone can read S_IRUSR | S_IWUSR | > > > S_IRCRP | S_IROTH (*). Please don't do this. > > Absolutely. It's *much* easier to parse and understand the octal > > numbers, while the symbolic macro names are just random line noise and > > hard as hell to understand. You really have to think about it. > > > > So we should rather go the other way: convert existing bad symbolic > > permission bit macro use to just use the octal numbers. > In addition to that I'd love to have something even easier to read, a few common  > variants of the permissions field of 'ls -l' pre-defined. I did some quick  > grepping, and collected the main variants that are in use: > > PERM_r________ 0400 > PERM_r__r_____ 0440 > PERM_r__r__r__ 0444 [etc] While the proposed PERM_ variants are easily read, using a single style instead of 2+ incompatible symbolic styles makes treewide misuse identification via grep style tools easier.