[PATCH v1] power: reset: reboot mode: fix build error of missing ioremap/iounmap on UM

[PATCH v1] power: reset: reboot mode: fix build error of missing ioremap/iounmap on UM

[Andy Yan]

commit 4fcd504edbf7 ("power: reset: add reboot mode driver") uses api from
syscon, and syscon uses ioremap/iounmap which depends on HAS_IOMEM, so
let's depend on MFD_SYSCON instead of selecting it directly to avoid the
um-allyesconfig like build error on archs that without iomem:

drivers/mfd/syscon.c: In function 'of_syscon_register':
drivers/mfd/syscon.c:67:9: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration]
  base = ioremap(res.start, resource_size(&res));
         ^
drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
  base = ioremap(res.start, resource_size(&res));
       ^
drivers/mfd/syscon.c:109:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]
  iounmap(base);
  ^

Reported-by: Kbuild test robot <fengguang.wu@intel.com>
Fixes: 4fcd504edbf7("power: reset: add reboot mode driver")
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>

---

Changes in v1:
- let this driver depend on MFD_SYSCON
- add Reported-by tag, which suggested by Krzysztof Kozlowski
- add Fixes tag, which suggested by Matthias Brugger

 drivers/power/reset/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
index 7053abc..10f8ddb 100644
--- a/drivers/power/reset/Kconfig
+++ b/drivers/power/reset/Kconfig
@@ -190,8 +190,8 @@ config REBOOT_MODE
 config SYSCON_REBOOT_MODE
 	tristate "Generic SYSCON regmap reboot mode driver"
 	depends on OF
+	depends on MFD_SYSCON
 	select REBOOT_MODE
-	select MFD_SYSCON
 	help
 	  Say y here will enable reboot mode driver. This will
 	  get reboot mode arguments and store it in SYSCON mapped
-- 
2.7.4

Re: [PATCH v1] power: reset: reboot mode: fix build error of missing ioremap/iounmap on UM

[Krzysztof Kozlowski]

On 08/12/2016 12:01 PM, Andy Yan wrote:
> commit 4fcd504edbf7 ("power: reset: add reboot mode driver") uses api from
> syscon, and syscon uses ioremap/iounmap which depends on HAS_IOMEM, so
> let's depend on MFD_SYSCON instead of selecting it directly to avoid the
> um-allyesconfig like build error on archs that without iomem:
> 
> drivers/mfd/syscon.c: In function 'of_syscon_register':
> drivers/mfd/syscon.c:67:9: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration]
>   base = ioremap(res.start, resource_size(&res));
>          ^
> drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>   base = ioremap(res.start, resource_size(&res));
>        ^
> drivers/mfd/syscon.c:109:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]
>   iounmap(base);
>   ^
> 
> Reported-by: Kbuild test robot <fengguang.wu@intel.com>
> Fixes: 4fcd504edbf7("power: reset: add reboot mode driver")
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> 
> ---
> 
> Changes in v1:
> - let this driver depend on MFD_SYSCON
> - add Reported-by tag, which suggested by Krzysztof Kozlowski
> - add Fixes tag, which suggested by Matthias Brugger
> 
>  drivers/power/reset/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

Re: [PATCH v1] power: reset: reboot mode: fix build error of missing ioremap/iounmap on UM

[Andy Yan]

Hi Sebastian:


On 2016年08月12日 20:48, Krzysztof Kozlowski wrote:
> On 08/12/2016 12:01 PM, Andy Yan wrote:
>> commit 4fcd504edbf7 ("power: reset: add reboot mode driver") uses api from
>> syscon, and syscon uses ioremap/iounmap which depends on HAS_IOMEM, so
>> let's depend on MFD_SYSCON instead of selecting it directly to avoid the
>> um-allyesconfig like build error on archs that without iomem:
>>
>> drivers/mfd/syscon.c: In function 'of_syscon_register':
>> drivers/mfd/syscon.c:67:9: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration]
>>    base = ioremap(res.start, resource_size(&res));
>>           ^
>> drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
>>    base = ioremap(res.start, resource_size(&res));
>>         ^
>> drivers/mfd/syscon.c:109:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]
>>    iounmap(base);
>>    ^
>>
>> Reported-by: Kbuild test robot <fengguang.wu@intel.com>
>> Fixes: 4fcd504edbf7("power: reset: add reboot mode driver")
>> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
>>
>> ---
>>
>> Changes in v1:
>> - let this driver depend on MFD_SYSCON
>> - add Reported-by tag, which suggested by Krzysztof Kozlowski
>> - add Fixes tag, which suggested by Matthias Brugger
>>
>>   drivers/power/reset/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Best regards,
> Krzysztof
>
>
>



  Will you please take this patch to avoid the Kbuild test robot warning ?

   Thanks

Re: [PATCH v1] power: reset: reboot mode: fix build error of missing ioremap/iounmap on UM

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 1928 bytes --]

Hi Andy,

On Tue, Aug 16, 2016 at 06:55:49PM +0800, Andy Yan wrote:
> On 2016年08月12日 20:48, Krzysztof Kozlowski wrote:
> > On 08/12/2016 12:01 PM, Andy Yan wrote:
> > > commit 4fcd504edbf7 ("power: reset: add reboot mode driver") uses api from
> > > syscon, and syscon uses ioremap/iounmap which depends on HAS_IOMEM, so
> > > let's depend on MFD_SYSCON instead of selecting it directly to avoid the
> > > um-allyesconfig like build error on archs that without iomem:
> > > 
> > > drivers/mfd/syscon.c: In function 'of_syscon_register':
> > > drivers/mfd/syscon.c:67:9: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration]
> > >    base = ioremap(res.start, resource_size(&res));
> > >           ^
> > > drivers/mfd/syscon.c:67:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> > >    base = ioremap(res.start, resource_size(&res));
> > >         ^
> > > drivers/mfd/syscon.c:109:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]
> > >    iounmap(base);
> > >    ^
> > > 
> > > Reported-by: Kbuild test robot <fengguang.wu@intel.com>
> > > Fixes: 4fcd504edbf7("power: reset: add reboot mode driver")
> > > Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> > > 
> > > ---
> > > 
> > > Changes in v1:
> > > - let this driver depend on MFD_SYSCON
> > > - add Reported-by tag, which suggested by Krzysztof Kozlowski
> > > - add Fixes tag, which suggested by Matthias Brugger
> > > 
> > >   drivers/power/reset/Kconfig | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
>  Will you please take this patch to avoid the Kbuild test robot warning ?

https://git.kernel.org/cgit/linux/kernel/git/sre/linux-power-supply.git/commit/?h=fixes&id=7a4947cf6f26b7d0a5db260d212f6df41a563d23

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]