From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932395AbcHLRuZ (ORCPT ); Fri, 12 Aug 2016 13:50:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32828 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932307AbcHLRuX (ORCPT ); Fri, 12 Aug 2016 13:50:23 -0400 Message-ID: <1471024216.32433.5.camel@redhat.com> Subject: Re: [patch 4 14/22] timer: Switch to a non cascading wheel From: Rik van Riel To: Jouni Malinen , Thomas Gleixner Cc: LKML , Ingo Molnar , Peter Zijlstra , Paul McKenney , Frederic Weisbecker , Chris Mason , Arjan van de Ven , rt@linutronix.de, George Spelvin , Len Brown , Josh Triplett , Eric Dumazet Date: Fri, 12 Aug 2016 13:50:16 -0400 In-Reply-To: References: <20160704093956.299369787@linutronix.de> <20160704094342.108621834@linutronix.de> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-b4o1Dy1nU200zLONfc48" Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 12 Aug 2016 17:50:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-b4o1Dy1nU200zLONfc48 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2016-08-11 at 18:21 +0300, Jouni Malinen wrote: > On Mon, Jul 4, 2016 at 12:50 PM, Thomas Gleixner > wrote: > > The current timer wheel has some drawbacks: > ... >=20 > It looks like this change (commit > 500462a9de657f86edaa102f8ab6bff7f7e43fc2 in linux.git) breaks one of > the automated test cases I'm using to test hostapd and wpa_supplicant > with mac80211_hwsim from the kernel. I'm not sure what exactly causes > this (did not really expect git bisect to point to timers..), but > this > seems to be very reproducible for me under kvm (though, this > apparently did not happen on another device, so I'm not completely > sure what it is needed to reproduce) with the ap_wps_er_http_proto > test cases failing to connect 20 TCP stream sockets to a server on > the > localhost. The client side is a python test script and the server is > hostapd. The failure shows up with about the 13th of those socket > connects failing while all others (both before and after this failed > one) going through. >=20 > Would you happen to have any idea why this commit has such a > difference in behavior?=C2=A0 I have a vague hypothesis, more of a question actually. How does the new timer wheel code handle lost timer ticks? If a KVM guest does not run for a while, because the host is scheduling something else, the guest generally only gets one timer tick after the guest is scheduled back in. If there are multiple lost ticks, they will remain lost. Could that cause the new timer wheel code to skip over timer buckets occasionally, or is this hypothesis bunk? --=20 All Rights Reversed. --=-b4o1Dy1nU200zLONfc48 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJXrgxZAAoJEM553pKExN6DzxYH/RH8oqgg9ojplLnGY5nMAsmy 1kM94cl4sG922EvFHg9qr0AsNcDlcWDU868ieVyEPFIdbmMe0a62BlQLO7VsWhiI xfJWHm3eAZmkg1WAYcIzhLu/TMiVMJbW7XCYv54qjo6sBxuLeK4ep1Ob3ktbo5m/ Q7a5FxG+antpmu9WxyUAuV5X3FSrqUnmpicd3f+O9lP0ATLv9ru4slt7QOSFMEN0 C8jK4zmYC21X+UwsoLKtMIt0FiYyB/LjfuwUoONEhr8t2O25MsArN4QzQsyoyjl/ IdEhhU0QHcTixVWlrUnzgkF9qr/fnE+/SFCzRDA5lePQG9AucXmy6tk/p1grBtY= =ti4e -----END PGP SIGNATURE----- --=-b4o1Dy1nU200zLONfc48--