From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752455AbcHOHHI (ORCPT ); Mon, 15 Aug 2016 03:07:08 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:55703 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751375AbcHOHHG (ORCPT ); Mon, 15 Aug 2016 03:07:06 -0400 Message-ID: <1471244821.14287.8.camel@mtksdaap41> Subject: Re: [PATCH 1/3] dt-bindings: thermal: Add binding document for Mediatek thermal controller From: dawei chien To: Matthias Brugger CC: Keerthy , Zhang Rui , "Eduardo Valentin" , Rob Herring , "Pawel Moll" , Mark Rutland , "Ian Campbell" , Kumar Gala , Russell King , , , , , , , "Sascha Hauer" , Fan Chen , "Eddie Huang" , Yingjoe Chen , Erin Lo Date: Mon, 15 Aug 2016 15:07:01 +0800 In-Reply-To: <8886eba0-7f3d-edf8-c6fb-a6535b3717da@gmail.com> References: <1467882386-40544-1-git-send-email-dawei.chien@mediatek.com> <1467882386-40544-2-git-send-email-dawei.chien@mediatek.com> <577E385C.9080501@ti.com> <1468227124.15776.29.camel@mtksdaap41> <8886eba0-7f3d-edf8-c6fb-a6535b3717da@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Matthias, On Thu, 2016-08-11 at 17:48 +0200, Matthias Brugger wrote: > > On 11/07/16 10:52, dawei chien wrote: > > Dear Keerthy, > > > > On Thu, 2016-07-07 at 16:39 +0530, Keerthy wrote: > >> > >> On Thursday 07 July 2016 02:36 PM, Dawei Chien wrote: > >>> This adds the device tree binding documentation for the mediatek thermal > >>> controller found on Mediatek MT2701. > >>> > >>> Signed-off-by: Dawei Chien > >>> --- > >>> .../bindings/thermal/mediatek-thermal.txt | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > >>> index 81f9a51..bb55e79 100644 > >>> --- a/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > >>> +++ b/Documentation/devicetree/bindings/thermal/mediatek-thermal.txt > >>> @@ -8,7 +8,7 @@ apmixedsys register space via AHB bus accesses, so a phandle to the APMIXEDSYS > >>> is also needed. > >>> > >>> Required properties: > >>> -- compatible: "mediatek,mt8173-thermal" > >>> +- compatible: "mediatek,mt8173-thermal" or "mediatek,mt2701-thermal" > >> > >> - compatible : > >> - "mediatek,mt8173-thermal" : For MT8173 family of SoCs > >> - "mediatek,mt2701-thermal" : For MT2701 family of SoCs > > > > Thank you, I will update it on next version. > > > > Do you know about the compability to older SoCs (e.g. mt6589)? > It might make sense to add mediatek,mtk-thermal if they are compatible > or nearly compatible. I agree with you that we should add mediatek,mtk-thermal for compatible or nearly compatible SoC. However, there is no more compatible SoC so far. Once we have such new nearly compatible SoC, we would update it on this binding document soon, thank you. BR, Dawei > >> > >>> - reg: Address range of the thermal controller > >>> - interrupts: IRQ for the thermal controller > >>> - clocks, clock-names: Clocks needed for the thermal controller. required > >>> > > > >