From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753430AbcHQTEA (ORCPT ); Wed, 17 Aug 2016 15:04:00 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34171 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752406AbcHQTD7 (ORCPT ); Wed, 17 Aug 2016 15:03:59 -0400 Message-ID: <1471460636.29842.20.camel@edumazet-glaptop3.roam.corp.google.com> Subject: Re: [PATCH v3] mm/slab: Improve performance of gathering slabinfo stats From: Eric Dumazet To: Aruna Ramakrishna Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Kravetz , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton Date: Wed, 17 Aug 2016 12:03:56 -0700 In-Reply-To: <1471458050-29622-1-git-send-email-aruna.ramakrishna@oracle.com> References: <1471458050-29622-1-git-send-email-aruna.ramakrishna@oracle.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-08-17 at 11:20 -0700, Aruna Ramakrishna wrote: ] > - list_for_each_entry(page, &n->slabs_full, lru) { > - if (page->active != cachep->num && !error) > - error = "slabs_full accounting error"; > - active_objs += cachep->num; > - active_slabs++; > - } Since you only removed this loop, you could track only number of full_slabs. This would avoid messing with n->num_slabs all over the places in fast path. Please also update slab_out_of_memory()