On Tue, 2016-08-16 at 10:38 +0800, Finlye Xiao wrote: > From: Finley Xiao > > This patch adds an of_property_read_s32_index() function to allow > reading a single indexed s32 value from a property containing multiple > s32 values. > > Signed-off-by: Finley Xiao NAK. Nobody should be using the old of_property_* functions any more anyway. You should be using the generic device_propery_* functions which work regardless of where the information comes from (actual DT vs. ACPI _DSD). So no, don't *add* any more of these functions. Only add the generic version. And if your driver isn't using the generic property functions... fix it. -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation