From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753290AbcHUS1W (ORCPT ); Sun, 21 Aug 2016 14:27:22 -0400 Received: from mout.gmx.net ([212.227.17.20]:59086 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752443AbcHUS1V (ORCPT ); Sun, 21 Aug 2016 14:27:21 -0400 From: Heinrich Schuchardt To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= Cc: David Airlie , Rex Zhu , Eric Huang , Jammy Zhou , Eric Yang , Vitaly Prosyak , =?UTF-8?q?Nils=20Wallm=C3=A9nius?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Heinrich Schuchardt Subject: [PATCH 1/1] drm/amd/powerplay: avoid NULL dereference, cz_hwmgr.c Date: Sun, 21 Aug 2016 20:27:02 +0200 Message-Id: <1471804022-3486-1-git-send-email-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.1.4 X-Provags-ID: V03:K0:ZBTSmACiS3HyHC83PA23NM9uXrH/JTWcfPg3099R4ZMZq8jiDFV Z4TgdlKEXLhYpXQaN5p2B7VSd7MzxTmHc2VoM+gKzKupiDzP7/iw4EukLf+aX6Gl9en/Eyu eJqe48v2ykbqBojGM1aC4yKiRb2tT+TH6KQ2LCL9U/8A4Uetmd061injM4/kiRS4hAFBZU7 xUJKANr+9ykOte0PGL0vg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Xe/bJMQNbSA=:P8deFaF1F6Se8ejEN6mWAO 1rYFAniv1eGNyYOnSZ7B1mQ3VlRHviOGcbgMYiAQOi2RKXUOaXnHLjQpH4wgiWZ4odAdQKNcR y4pNAnINGzmD35TXWzex40RCX4meC1cZHby3ARAakm8ZUrMLlZU4Nba1UQ/0VjSAWubMk+hVC DhBAnY4kjjUfIVdbF+04ZiimaApEd+HX52Aai7oALNImV4qRZ7rKZEvXEfh5aNf1sjq3HMVT5 FM9LhSkGY6btHHRsCVuUL/DCkHRlZ+u2lPkNggGDlFl+7roW3s+gfD0U3kxeWVPcqNrtrFKzB dbxEEbuY6D0nN+EL5rrJBAOFgJ4eRiHjpqw6g+tIWy+YYo065rxAcVOVPMzXonvxfRsJYoEw3 Rv1+XUAVcK1Mtet1OcarJVg/O3U0gskeofkC+8wHRJYQafzyzpP+I1AZ8rdJPlqRCGPhbRXh4 uiNUBffsZuoocGKvFTVAttoEJ4kmONOwrw7o0V9GJAe8nrXTiZJ2TyLq380iDqsmh+jd/U3pt /MhR5Sqw7o9ZHomM+SQtz3eK1Kh8Ub8cfRTzFrXuAHPdLZOEaMd29KTQ1WreawM8Jk+4WIRo+ TYHYI0HifRflSGgdhe8cizn9DgXjvIF8KGsqUVz2DH5r3FlJHRK3469izFJerfTSN3g6PU7D2 3KvLYdLQLbwrHQFGLzlRtqL+KP0JrpGwu0sGW4kytM6clGUKqqwfed2RIaPPLghQcmdL9SVuV nIz3YhmarQHm+fxHX8Do7B0BxCmYoc5i1K/C7uQPICiKE9VgA9H1UEujlro= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org if (a == NULL || a->b == NULL) leads to a NULL pointer dereference if a == NULL. Signed-off-by: Heinrich Schuchardt --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c index 8cc0df9..5e2d4cf 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c @@ -1246,7 +1246,7 @@ static int cz_hwmgr_backend_init(struct pp_hwmgr *hwmgr) static int cz_hwmgr_backend_fini(struct pp_hwmgr *hwmgr) { - if (hwmgr != NULL || hwmgr->backend != NULL) { + if (hwmgr != NULL && hwmgr->backend != NULL) { kfree(hwmgr->backend); kfree(hwmgr); } -- 2.1.4