From: Markus Elfring <Markus.Elfring@web.de>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-arm-msm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] misc: fastrpc: fix memory leak
Date: Wed, 29 Apr 2020 22:40:14 +0200 [thread overview]
Message-ID: <1471e6f6-fd20-334a-041b-9d55be234111@web.de> (raw)
> if misc_register() fails, previously allocated data is left without freeing,
> this could result in memory leak.
How do you think about a wording variant like the following?
Subject:
[PATCH v2] misc: fastrpc: Fix an incomplete memory release in fastrpc_rpmsg_probe()
Change description:
A few fastrpc data were not released after a call of the
function “misc_register” failed.
Thus add a call of the function “kfree”.
> So fix it!
Would you like to replace such an information by the tag “Fixes”?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=96c9a7802af7d500a582d89a8b864584fe878c1b#n183
Regards,
Markus
next reply other threads:[~2020-04-29 20:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 20:40 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-29 15:29 [PATCH] misc: fastrpc: fix memory leak Srinivas Kandagatla
2020-04-30 5:02 ` Bjorn Andersson
2019-07-04 16:25 Jorge Ramirez-Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471e6f6-fd20-334a-041b-9d55be234111@web.de \
--to=markus.elfring@web.de \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).