From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1758227AbcHYHXS (ORCPT <rfc822;w@1wt.eu>);
        Thu, 25 Aug 2016 03:23:18 -0400
Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:42954 "EHLO
        metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1756052AbcHYHXR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 25 Aug 2016 03:23:17 -0400
Message-ID: <1472109780.3032.20.camel@pengutronix.de>
Subject: Re: [PATCH 06/10] reset: socfpga: add driver Kconfig option
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Dinh Nguyen <dinguyen@opensource.altera.com>
Cc: linux-kernel@vger.kernel.org,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Arnd Bergmann <arnd@arndb.de>, Axel Lin <axel.lin@ingics.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Lee Jones <lee.jones@linaro.org>, linux-arm-kernel@lists.infradead.org
Date: Thu, 25 Aug 2016 09:23:00 +0200
In-Reply-To: <57BDBCB0.30607@opensource.altera.com>
References: <1472045342-7434-1-git-send-email-p.zabel@pengutronix.de>
         <1472045342-7434-6-git-send-email-p.zabel@pengutronix.de>
         <57BDBCB0.30607@opensource.altera.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.9-1+b1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969
X-SA-Exim-Mail-From: p.zabel@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Mittwoch, den 24.08.2016, 10:26 -0500 schrieb Dinh Nguyen:
> Hi Philipp,
> 
> just a minor nit:
> 
> On 08/24/2016 08:28 AM, Philipp Zabel wrote:
> > Visible only if COMPILE_TEST is enabled, this allows to include the
> > driver in build tests.
> > 
> > Cc: Dinh Nguyen <dinguyen@opensource.altera.com>
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> >  drivers/reset/Kconfig  | 6 ++++++
> >  drivers/reset/Makefile | 2 +-
> >  2 files changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> > index 6ac631e..354e281 100644
> > --- a/drivers/reset/Kconfig
> > +++ b/drivers/reset/Kconfig
> > @@ -49,6 +49,12 @@ config RESET_PISTACHIO
> >  	help
> >  	  This enables the reset driver for ImgTec Pistachio SoCs.
> >  
> > +config RESET_SOCFPGA
> > +	bool "SoC FPGA Reset Driver" if COMPILE_TEST
> 
> Prefer to be "SoCFPGA", no space in between.
>
[...]
> 
> Otherwise,
> 
> Acked-by: Dinh Nguyen <dinguyen@opensource.altera.com>

Thank you, I'll fix this.

regards
Philipp