From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933599AbcHYMG3 (ORCPT ); Thu, 25 Aug 2016 08:06:29 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:46665 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751774AbcHYMG1 (ORCPT ); Thu, 25 Aug 2016 08:06:27 -0400 From: Alexey Brodkin To: "liavr@mellanox.com" CC: Cupertino Miranda , "linux-kernel@vger.kernel.org" , "eladkan@mellanox.com" , "noamca@mellanox.com" , "Vineet Gupta" , "linux-snps-arc@lists.infradead.org" Subject: Re: [PATCH] ARC: Change ld.as instruction to regular ld. Thread-Topic: [PATCH] ARC: Change ld.as instruction to regular ld. Thread-Index: AQHR+FAZOt5XJRL38UusB3nSD4V+WKBZfzIA Date: Thu, 25 Aug 2016 12:05:19 +0000 Message-ID: <1472126602.2600.14.camel@synopsys.com> References: <1471415037-14544-1-git-send-email-liavr@mellanox.com> In-Reply-To: <1471415037-14544-1-git-send-email-liavr@mellanox.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.14.110] Content-Type: text/plain; charset="utf-8" Content-ID: <87036ABE3CBFA742BDCF2DDCFD57DD61@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u7PC6Xnx004219 Hi Liav, On Wed, 2016-08-17 at 09:23 +0300, Liav Rehana wrote: > From: Liav Rehana > > User mode callee regs are explicitly collected before signal delivery > or breakpoint trap. r25 is special for kernel as it serves as task > pointer, so user mode value is clobbered very early. It is saved in > pt_regs where generally only scratch (caller saved) res are saved. > The code to access the corresponding pt_regs location had a subtle bug > as it was using load/store with scaling of offset, whereas the offset > was already byte wise correct. So fix this by replacing LD.AS with a > standard LD > > Signed-off-by: Liav Rehana That nice patch really fixes quite annoying issue when r25 got printed improperly in gdb! So Tested-by: Alexey Brodkin