From: Chao Yu <chao@kernel.org>
To: tytso@mit.edu, jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Chao Yu <yuchao0@huawei.com>
Subject: [PATCH] fscrypto: fix to null-terminate encrypted filename in fname_encrypt
Date: Sun, 28 Aug 2016 09:13:28 +0800 [thread overview]
Message-ID: <1472346808-3213-1-git-send-email-chao@kernel.org> (raw)
From: Chao Yu <yuchao0@huawei.com>
This patch fixes to add null character at the end of encrypted filename
in fname_encrypt, in order to avoid incorrectly traversing random data
located after target filename. The call stack is as below:
- f2fs_add_link
- __f2fs_add_link
- fscrypt_setup_filename
- fscrypt_fname_alloc_buffer allocate buffer for @fname
- fname_encrypt didn't set null character for @fname
- f2fs_add_regular_entry init qstr with @fname
- init_inode_metadata
- f2fs_init_security
- security_inode_init_security
- selinux_inode_init_security
- selinux_determine_inode_label
- security_transition_sid
- security_compute_sid
- filename_compute_type
- hashtab_search
- filenametr_hash traverse @fname as one which has null character
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
fs/crypto/fname.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/crypto/fname.c b/fs/crypto/fname.c
index 5d6d491..5c356c0 100644
--- a/fs/crypto/fname.c
+++ b/fs/crypto/fname.c
@@ -110,6 +110,7 @@ static int fname_encrypt(struct inode *inode,
"%s: Error (error code %d)\n", __func__, res);
oname->len = ciphertext_len;
+ oname->name[oname->len] = 0;
return res;
}
--
2.7.2
next reply other threads:[~2016-08-28 1:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-28 1:13 Chao Yu [this message]
2016-08-28 5:13 ` [PATCH] fscrypto: fix to null-terminate encrypted filename in fname_encrypt Theodore Ts'o
2016-08-28 6:16 ` Chao Yu
2016-08-29 14:55 ` [f2fs-dev] " Chao Yu
2016-08-29 17:51 ` Jaegeuk Kim
2016-08-29 19:08 ` Theodore Ts'o
2016-08-30 16:10 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472346808-3213-1-git-send-email-chao@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).